yeatmanlab / roar-dashboard

A dashboard to administer ROAR assessments
https://roar.education
Other
4 stars 4 forks source link

Offload computeAssignmentTaskData in Score Report to Web Worker #678

Closed lucasxsong closed 3 months ago

lucasxsong commented 3 months ago

Proposed changes

Types of changes

What types of changes does this pull request introduce?

Checklist

Justification of missing checklist items

Further comments

github-actions[bot] commented 3 months ago

Visit the preview URL for this PR (updated for commit afe9b49):

https://roar-staging--pr678-refactor-compute-tas-m8dobstt.web.app

(expires Tue, 09 Jul 2024 19:34:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

cypress[bot] commented 3 months ago

Passing run #3590 ↗︎

0 20 0 0 Flakiness 0

Details:

Tests for PR 678 "Offload computeAssignmentTaskData in Score Report to Web Worke...
Project: roar-dashboard-e2e Commit: afe9b49dd6
Status: Passed Duration: 01:52 💡
Started: Jul 2, 2024 7:34 PM Ended: Jul 2, 2024 7:36 PM

Review all test suite changes for PR #678 ↗︎

lucasxsong commented 3 months ago

Upon performance analysis comparing the refactored worker pattern compared to our current pattern, I was unable to find substantial increases in performance, and even witnessed a longer load time in our largest data set (Springfield ~17s vs ~22s)

Screenshot 2024-07-09 at 4 00 11 PM Screenshot 2024-07-09 at 3 51 25 PM

s

Screenshot 2024-07-09 at 3 53 57 PM