yeatmanlab / roar-dashboard

A dashboard to administer ROAR assessments
https://roar.education
Other
4 stars 4 forks source link

Upstream sync 1 #682

Open Zio-4 opened 3 months ago

Zio-4 commented 3 months ago

Proposed changes

This is the first upstream sync from the LEVANTE fork. The following changes are included

Types of changes

What types of changes does this pull request introduce?

Checklist

Justification of missing checklist items

Further comments

richford commented 3 months ago

@ksmontville, @lucasxsong, @Emily-ejag, @kellyel: Can one of you explain why the Cypress tests did not run on this PR and what we can do to change that?

ksmontville commented 3 months ago

@ksmontville, @lucasxsong, @Emily-ejag, @kellyel: Can one of you explain why the Cypress tests did not run on this PR and what we can do to change that?

I believe that is is because of the merge conflicts. Any action that is triggered by a pull request will not run if the incoming branch has merge conflicts, according to the docs.

"Notes: Workflows will not run on pull_request activity if the pull request has a merge conflict. The merge conflict must be resolved first."

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request

GitHub Docs
Events that trigger workflows - GitHub Docs
You can configure your workflows to run when specific activity on GitHub happens, at a scheduled time, or when an event outside of GitHub occurs.