Add refreshDocs function to HomeParticipant.vue

richford commented 3 months ago

Proposed changes

This PR attempts to fix an issue where Clever and ClassLink users see no assignments until page refresh.

Previously, before our consent picker refactor, the HomeSelector.vue component would wait for the delayed event from the ConsentModal.vue component and then refresh user docs when it received the event. After that refactor, we forgot to port that behavior into HomeParticipant.vue. This PR remedies that.

Types of changes

What types of changes does this pull request introduce?

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
[ ] Documentation Update
[ ] Tests (new or updated tests)
[x] Style (changes to code styling)
[ ] CI (continuous integration changes)
[ ] Repository Maintenance
[ ] Other (please describe below)

Checklist

[x] I have read the guidelines for contributing.
[x] The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
[x] Linting checks pass with my changes.
[x] Any existing unit tests pass with my changes.
[x] Any existing end-to-end tests pass with my changes.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
[x] I have added JSDoc comments as appropriate.
[x] I have added the necessary documentation to the roar-docs repository.
[ ] I have shared this PR on the roar-pr-reviews channel (if I have access)
[x] I have linked relevant issues (if any)

Justification of missing checklist items

We cannot currently end-to-end test Clever or ClassLink integration.

github-actions[bot] commented 3 months ago

Visit the preview URL for this PR (updated for commit b0abaa1):

https://roar-staging--pr683-bf-add-refresh-docs-twh2rwh9.web.app

_{(expires Sat, 29 Jun 2024 13:08:31 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460}

ROAR

cypress[bot] commented 3 months ago

1 failed test on run #2832 ↗︎

1

19

0

Details:

Tests for PR 683 "Add refreshDocs function to HomeParticipant.vue" from commit "...
Project: roar-dashboard-e2e	Commit: `b0abaa1e22`
Status: Failed	Duration: 03:50 💡
Started: Jun 22, 2024 1:17 PM	Ended: Jun 22, 2024 1:21 PM

cypress/e2e/participant/default-tests/playVideo.cy.js • 1 failed test

View Output

Test		Artifacts
Playing Video > plays-video		`Test Replay` `Screenshots`

yeatmanlab / roar-dashboard