Change Password

[kellyel]

Proposed changes

Adds a section on the edit users modal to allow for changing a user's password.

Types of changes

What types of changes does this pull request introduce?

• [ ] Bugfix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
• [ ] Documentation Update
• [ ] Tests (new or updated tests)
• [ ] Style (changes to code styling)
• [ ] CI (continuous integration changes)
• [ ] Repository Maintenance
• [ ] Other (please describe below)

Checklist

• [x] I have read the guidelines for contributing.
• [x] The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
• [x] Linting checks pass with my changes.
• [x] Any existing unit tests pass with my changes.
• [x] Any existing end-to-end tests pass with my changes.
• [x] I have added tests that prove my fix is effective or that my feature works.
• [x] If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
• [x] I have added JSDoc comments as appropriate.
• [x] I have added the necessary documentation to the roar-docs repository.
• [x] I have shared this PR on the roar-pr-reviews channel (if I have access)
• [x] I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

[github-actions[bot]]

Visit the preview URL for this PR (updated for commit c9b3a4a):

https://roar-staging--pr686-enh-change-password-ihfu80vd.web.app

_{(expires Wed, 10 Jul 2024 16:37:19 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460}

[cypress[bot]]

Passing run #3618 ↗︎

0

20

0

0

0

Details:

Tests for PR 686 "Change Password" from commit "c9b3a4a6d49da939aef2281ee6ebfaad...
Project: roar-dashboard-e2e	Commit: c9b3a4a6d4
Status: Passed	Duration: 02:10 💡
Started: Jul 3, 2024 4:37 PM	Ended: Jul 3, 2024 4:39 PM

Review all test suite changes for PR #686 ↗︎

[kellyel]

I'm thinking that the change password input boxes should only show up if the user clicks on a "Change password" button. And then that could render the "New password" and "Confirm password" boxes and a separate "Update password" button that would be separate from the rest of the form.

Take a look at how GitHub handles password updating for what I'm thinking here. Mostly I'm worries about accidental input, either from the admin user or from an admin user's password manager. What do you think?

I agree. I was thinking about a way to separate this functionality out without being too intrusive to the user experience. Something like this may be a good solution. Thanks for the feedback!