yeatmanlab / roar-dashboard

A dashboard to administer ROAR assessments
https://roar.education
Other
4 stars 4 forks source link

Adding condition to rawScores to display on tooltip #690

Closed Emily-ejag closed 3 months ago

Emily-ejag commented 3 months ago

Proposed changes

If the rawScore === 0 then it will be displayed on the tooltip

Types of changes

What types of changes does this pull request introduce?

Checklist

Justification of missing checklist items

Further comments

github-actions[bot] commented 3 months ago

Visit the preview URL for this PR (updated for commit 91c6754):

https://roar-staging--pr690-fix-rawscore-not-sho-y1x6mvoi.web.app

(expires Tue, 02 Jul 2024 02:22:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

cypress[bot] commented 3 months ago

Passing run #2877 ↗︎

0 20 0 0 Flakiness 0

Details:

Tests for PR 690 "Adding condition to rawScores to display on tooltip" from comm...
Project: roar-dashboard-e2e Commit: 91c675442e
Status: Passed Duration: 02:02 💡
Started: Jun 25, 2024 2:22 AM Ended: Jun 25, 2024 2:24 AM

Review all test suite changes for PR #690 ↗︎

lucasxsong commented 3 months ago

On this PR's staging link, it now appears that the Phoneme scores are not showing up. Not sure if this was introduced by this PR or not, but I will investigate on staging.

Screenshot 2024-06-25 at 9 29 43 AM