Check if user is undefined/null before routing to home in CleverLanding.vue and ClassLinkLanding.vue

richford commented 3 months ago

Proposed changes

This PR fixes a bug in which Clever and ClassLink users were being prematurely routed to home before their assignments were ready.

What types of changes does this pull request introduce?

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
[ ] Documentation Update
[ ] Tests (new or updated tests)
[ ] Style (changes to code styling)
[ ] CI (continuous integration changes)
[ ] Repository Maintenance
[ ] Other (please describe below)

[x] I have read the guidelines for contributing.
[x] The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
[x] Linting checks pass with my changes.
[x] Any existing unit tests pass with my changes.
[x] Any existing end-to-end tests pass with my changes.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
[x] I have added JSDoc comments as appropriate.
[x] I have added the necessary documentation to the roar-docs repository.
[x] I have shared this PR on the roar-pr-reviews channel (if I have access)
[ ] I have linked relevant issues (if any)

We are currently unable to test Clever/ClassLink integration in our end-to-end testing suite.

github-actions[bot] commented 3 months ago

Visit the preview URL for this PR (updated for commit 801f73f):

_{(expires Thu, 04 Jul 2024 17:09:21 GMT)}

_{Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460}

ROAR

cypress[bot] commented 3 months ago

0

26

0

Details:

Tests for PR 696 "Check if user is undefined/null before routing to home in Clev...
Project: roar-dashboard-e2e	Commit: `801f73f7a9`
Status: Passed	Duration: 03:47 💡
Started: Jun 27, 2024 5:09 PM	Ended: Jun 27, 2024 5:13 PM