WIP: AdobeSign integration

Emily-ejag commented 3 months ago

Proposed changes

Please first link this branch with this PR on firekit: AdobeSign Firekit

-- Adding identical files from AdobeSign to the Legal section. -- Introducing an Adobe Sign checkbox in the Consent Picker, saving the legal documents under the legal directory in the administration. -- On the homeParticipant check, verify if the adobeSign flag exists. If it does, it ask to input your email, then you have 20 retrys of 5 sec each to sign, if not you need to start the process again. -- If the signing is successful then the student document gets updated with the consent form

ON PARENT SIGNUP for using adobe on parent signup the route is roar.education/register-clinic

Types of changes

What types of changes does this pull request introduce?

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
[ ] Documentation Update
[ ] Tests (new or updated tests)
[ ] Style (changes to code styling)
[ ] CI (continuous integration changes)
[ ] Repository Maintenance
[ ] Other (please describe below)

Checklist

[x] I have read the guidelines for contributing.
[x] The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
[x] Linting checks pass with my changes.
[x] Any existing unit tests pass with my changes.
[x] Any existing end-to-end tests pass with my changes.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
[ ] I have added JSDoc comments as appropriate.
[ ] I have added the necessary documentation to the roar-docs repository.
[ ] I have shared this PR on the roar-pr-reviews channel (if I have access)
[ ] I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

github-actions[bot] commented 3 months ago

Visit the preview URL for this PR (updated for commit c381dfe):

https://roar-staging--pr704-enh-adobe-sign-totrhgh5.web.app

_{(expires Tue, 23 Jul 2024 17:42:59 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460}

cypress[bot] commented 3 months ago

Passing run #4260 ↗︎

0

26

0

Details:

Tests for PR 704 "WIP: AdobeSign integration" from commit "c381dfe43306ece7e367d...
Project: roar-dashboard-e2e	Commit: `c381dfe433`
Status: Passed	Duration: 03:45 💡
Started: Jul 16, 2024 5:42 PM	Ended: Jul 16, 2024 5:46 PM

Review all test suite changes for PR #704 ↗︎

gitguardian[bot] commented 3 months ago

⚠️ GitGuardian has uncovered 12 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [12619882](https://dashboard.gitguardian.com/workspace/496782/incidents/12619882?occurrence=154875683) | Triggered | Bearer Token | 7f6bd420a115bbd9c0a7cbd968364e9255e408be | src/pages/HomeParticipant.vue | [View secret](https://github.com/yeatmanlab/roar-dashboard/commit/7f6bd420a115bbd9c0a7cbd968364e9255e408be#diff-79b0d2ac28bdd88126aa384965e32e037bb8acd886b65c166e770014d5eea905R238) | | [12619882](https://dashboard.gitguardian.com/workspace/496782/incidents/12619882?occurrence=154875684) | Triggered | Bearer Token | 7f6bd420a115bbd9c0a7cbd968364e9255e408be | src/pages/HomeParticipant.vue | [View secret](https://github.com/yeatmanlab/roar-dashboard/commit/7f6bd420a115bbd9c0a7cbd968364e9255e408be#diff-79b0d2ac28bdd88126aa384965e32e037bb8acd886b65c166e770014d5eea905R268) | | [12619882](https://dashboard.gitguardian.com/workspace/496782/incidents/12619882?occurrence=157325433) | Triggered | Bearer Token | 17ac3bf57277bd9cc53d13c52262d22427bb0689 | src/pages/HomeParticipant.vue | [View secret](https://github.com/yeatmanlab/roar-dashboard/commit/17ac3bf57277bd9cc53d13c52262d22427bb0689#diff-79b0d2ac28bdd88126aa384965e32e037bb8acd886b65c166e770014d5eea905L238) | | [12619882](https://dashboard.gitguardian.com/workspace/496782/incidents/12619882?occurrence=157325434) | Triggered | Bearer Token | 17ac3bf57277bd9cc53d13c52262d22427bb0689 | src/pages/HomeParticipant.vue | [View secret](https://github.com/yeatmanlab/roar-dashboard/commit/17ac3bf57277bd9cc53d13c52262d22427bb0689#diff-79b0d2ac28bdd88126aa384965e32e037bb8acd886b65c166e770014d5eea905L268) | | [12783946](https://dashboard.gitguardian.com/workspace/496782/incidents/12783946?occurrence=157325435) | Triggered | Bearer Token | 17ac3bf57277bd9cc53d13c52262d22427bb0689 | src/helpers/query/adobeSign.js | [View secret](https://github.com/yeatmanlab/roar-dashboard/commit/17ac3bf57277bd9cc53d13c52262d22427bb0689#diff-bbe7e34b555f2371d9f06d9c44287f73ea23613df69a110c51ff3e152ec94a30R6) | | [12783946](https://dashboard.gitguardian.com/workspace/496782/incidents/12783946?occurrence=158166186) | Triggered | Bearer Token | 45a1c67164e6ed55e8c8f2d7ea078cdb2e47a180 | src/helpers/query/adobeSign.js | [View secret](https://github.com/yeatmanlab/roar-dashboard/commit/45a1c67164e6ed55e8c8f2d7ea078cdb2e47a180#diff-bbe7e34b555f2371d9f06d9c44287f73ea23613df69a110c51ff3e152ec94a30L6) | | [12783947](https://dashboard.gitguardian.com/workspace/496782/incidents/12783947?occurrence=157325432) | Triggered | Bearer Token | 17ac3bf57277bd9cc53d13c52262d22427bb0689 | src/helpers/query/adobeSign.js | [View secret](https://github.com/yeatmanlab/roar-dashboard/commit/17ac3bf57277bd9cc53d13c52262d22427bb0689#diff-bbe7e34b555f2371d9f06d9c44287f73ea23613df69a110c51ff3e152ec94a30R50) | | [12783947](https://dashboard.gitguardian.com/workspace/496782/incidents/12783947?occurrence=158166185) | Triggered | Bearer Token | 45a1c67164e6ed55e8c8f2d7ea078cdb2e47a180 | src/helpers/query/adobeSign.js | [View secret](https://github.com/yeatmanlab/roar-dashboard/commit/45a1c67164e6ed55e8c8f2d7ea078cdb2e47a180#diff-bbe7e34b555f2371d9f06d9c44287f73ea23613df69a110c51ff3e152ec94a30L50) | | [12880271](https://dashboard.gitguardian.com/workspace/496782/incidents/12880271?occurrence=158166184) | Triggered | Bearer Token | 099d95b5a41bde65314c5ed3dca50dfaf9d241bf | src/helpers/query/adobeSign.js | [View secret](https://github.com/yeatmanlab/roar-dashboard/commit/099d95b5a41bde65314c5ed3dca50dfaf9d241bf#diff-bbe7e34b555f2371d9f06d9c44287f73ea23613df69a110c51ff3e152ec94a30L6) | | [12880271](https://dashboard.gitguardian.com/workspace/496782/incidents/12880271?occurrence=158166187) | Triggered | Bearer Token | 099d95b5a41bde65314c5ed3dca50dfaf9d241bf | src/helpers/query/adobeSign.js | [View secret](https://github.com/yeatmanlab/roar-dashboard/commit/099d95b5a41bde65314c5ed3dca50dfaf9d241bf#diff-bbe7e34b555f2371d9f06d9c44287f73ea23613df69a110c51ff3e152ec94a30L50) | | [12880271](https://dashboard.gitguardian.com/workspace/496782/incidents/12880271?occurrence=158166188) | Triggered | Bearer Token | 45a1c67164e6ed55e8c8f2d7ea078cdb2e47a180 | src/helpers/query/adobeSign.js | [View secret](https://github.com/yeatmanlab/roar-dashboard/commit/45a1c67164e6ed55e8c8f2d7ea078cdb2e47a180#diff-bbe7e34b555f2371d9f06d9c44287f73ea23613df69a110c51ff3e152ec94a30R50) | | [12880271](https://dashboard.gitguardian.com/workspace/496782/incidents/12880271?occurrence=158166189) | Triggered | Bearer Token | 45a1c67164e6ed55e8c8f2d7ea078cdb2e47a180 | src/helpers/query/adobeSign.js | [View secret](https://github.com/yeatmanlab/roar-dashboard/commit/45a1c67164e6ed55e8c8f2d7ea078cdb2e47a180#diff-bbe7e34b555f2371d9f06d9c44287f73ea23613df69a110c51ff3e152ec94a30R6) |

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/bearer_token#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

richford commented 3 months ago

@Emily-ejag , we've moved the integration token to Google Secret Manager. But there are still the old integration tokens in the git commit history. Can you look through the tokens identified here and delete them from your adobe sign developer account. Then we can dismiss the GitGuardian checks that are failing.

Emily-ejag commented 3 months ago

Created a new PR (https://github.com/yeatmanlab/roar-dashboard/pull/716) to not have security issues

yeatmanlab / roar-dashboard