yeatmanlab / roar-dashboard

A dashboard to administer ROAR assessments
https://roar.education
Other
4 stars 4 forks source link

Add Participant Tests with Clever Auth #710

Closed lucasxsong closed 3 months ago

lucasxsong commented 3 months ago

Proposed changes

Types of changes

What types of changes does this pull request introduce?

Checklist

Justification of missing checklist items

Further comments

github-actions[bot] commented 3 months ago

Visit the preview URL for this PR (updated for commit ddf3ba3):

https://roar-staging--pr710-enh-clever-participa-m50xcmc8.web.app

(expires Fri, 19 Jul 2024 22:38:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

cypress[bot] commented 3 months ago

Passing run #4213 ↗︎

0 26 0 0 Flakiness 0

Details:

Tests for PR 710 "Add Participant Tests with Clever Auth" from commit "ddf3ba344...
Project: roar-dashboard-e2e Commit: ddf3ba3442
Status: Passed Duration: 03:25 💡
Started: Jul 12, 2024 10:36 PM Ended: Jul 12, 2024 10:40 PM

Review all test suite changes for PR #710 ↗︎

gitguardian[bot] commented 3 months ago

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [13028510](https://dashboard.gitguardian.com/workspace/496782/incidents/13028510?occurrence=160482837) | Triggered | Username Password | a9e077124756862a133fbcd27cc36372b2acc800 | cypress.config.js | [View secret](https://github.com/yeatmanlab/roar-dashboard/commit/a9e077124756862a133fbcd27cc36372b2acc800#diff-5bae461d15457335f3d6285d35d3df2fd618e583eb7460c52cd8f0de69627abcR39) | | [13028510](https://dashboard.gitguardian.com/workspace/496782/incidents/13028510?occurrence=160483141) | Triggered | Username Password | 1547de05149bf68da8b1b2bb42e83f29c260c069 | cypress.config.js | [View secret](https://github.com/yeatmanlab/roar-dashboard/commit/1547de05149bf68da8b1b2bb42e83f29c260c069#diff-5bae461d15457335f3d6285d35d3df2fd618e583eb7460c52cd8f0de69627abcL39) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/username_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.