yeatmanlab / roar-dashboard

A dashboard to administer ROAR assessments
https://roar.education
Other
4 stars 4 forks source link

Primevue Update #720

Closed Emily-ejag closed 2 months ago

Emily-ejag commented 2 months ago

Proposed changes

Types of changes

What types of changes does this pull request introduce?

Checklist

Justification of missing checklist items

Further comments

github-actions[bot] commented 2 months ago

Visit the preview URL for this PR (updated for commit 59679ba):

https://roar-staging--pr720-enh-primeview-update-b6ljxffb.web.app

(expires Fri, 23 Aug 2024 19:34:02 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

cypress[bot] commented 2 months ago



Test summary

26 0 0 0Flakiness 0


Run details

Project roar-dashboard-e2e
Status Passed
Commit 59679bac30
Started Aug 16, 2024 7:33 PM
Ended Aug 16, 2024 7:37 PM
Duration 04:32 💡
OS Linux Ubuntu -
Browser Edge 127

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Zio-4 commented 2 months ago

Is this WIP?

Everything is dark and the sign in page input stretched outside of it's container Screenshot 2024-08-01 at 1 37 45 PM Screenshot 2024-08-01 at 1 38 24 PM

richford commented 2 months ago

Additionally, the menu collapse isn't behaving as before. When I change the width of the browser, I get the following:

Screenshot 2024-08-15 at 3 10 17 PM

and

Screenshot 2024-08-15 at 3 07 35 PM
richford commented 2 months ago

Oh I see, thanks @Emily-ejag. Sorry, I misunderstood. You already had a fix for that merged. Thanks for explicitly showing that to me.