Enh/isr add letter - Githubissues

kellyel commented 2 months ago

Proposed changes

This PR adds letter to the individual score report page. It is listed as a raw score task.

Types of changes

What types of changes does this pull request introduce?

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
[ ] Documentation Update
[ ] Tests (new or updated tests)
[ ] Style (changes to code styling)
[ ] CI (continuous integration changes)
[ ] Repository Maintenance
[ ] Other (please describe below)

Checklist

[x] I have read the guidelines for contributing.
[x] The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
[x] Linting checks pass with my changes.
[x] Any existing unit tests pass with my changes.
[x] Any existing end-to-end tests pass with my changes.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
[x] I have added JSDoc comments as appropriate.
[x] I have added the necessary documentation to the roar-docs repository.
[ ] I have shared this PR on the roar-pr-reviews channel (if I have access)
[x] I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

github-actions[bot] commented 2 months ago

Visit the preview URL for this PR (updated for commit 33b4e1c):

https://roar-staging--pr744-enh-isr-add-letter-6440i5o3.web.app

_{(expires Thu, 22 Aug 2024 23:01:44 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460}

cypress[bot] commented 2 months ago

Test summary

26 • 0 • 0 • 0 • 0

Run details


Project	roar-dashboard-e2e
Status	Passed
Commit	33b4e1cc5e
Started	Aug 15, 2024 11:01 PM
Ended	Aug 15, 2024 11:05 PM
Duration	04:09 💡
OS	Linux Ubuntu -
Browser	Chromium 127

View run in Cypress Cloud ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Emily-ejag commented 2 months ago

The tables for each game are not appearing, is this intended. I believe this should show:

github-actions[bot] commented 2 months ago

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	0.96%	73 / 7549
🔵	Statements	0.92%	74 / 8039
🔵	Functions	0.69%	14 / 2006
🔵	Branches	0.47%	20 / 4215

File Coverage

File	Stmts	% Branch	% Funcs	% Lines	Uncovered Lines
Changed Files
src/components/reports/IndividualScoreReportTask.vue	0%	0%	0%	0%	155-156, 158, 173, 175-179, 176, 176-178, 177-178, 181, 181, 183, 185-347, 186, 188-341, 189-201, 194-198, 195, 197, 200, 202-340, 203-206, 208-230, 233-248, 235-240, 242-247, 249-267, 250-259, 256, 261-266, 270-273, 272, 275-280, 283-289, 284-287, 286, 288, 291-326, 292-296, 296-297, 297-298, 298, 300, 302-326, 307-314, 312, 316, 318-325, 329, 331-333, 332, 332, 335-337, 336, 339, 344-346, 345-346, 350-359, 352-358, 353-358, 355-358, 357, 363-371, 364-371, 366-371, 368, 370, 375-383, 376-383, 378-383, 380, 382, 3-7, 10, 102-103, 107, 120, 124

Generated in workflow #12