yeatmanlab / roar-dashboard

A dashboard to administer ROAR assessments
https://roar.education
Other
4 stars 4 forks source link

Toggle Test Admins in Super Admin View #749

Closed ksmontville closed 1 month ago

ksmontville commented 1 month ago

Proposed changes

This PR adds a toggle to remove test administrations from the super admin view. It also fixes an issue with the checkLegalDoc.cy.js Cypress test.

TODO:

Firebase Functions PR: https://github.com/yeatmanlab/roar-firebase-functions/pull/267 (MERGED)

Concerns:

  1. Not all administrations include a testData field, which means admins that are not intended to be test data will still be filtered out
  2. Write a local function which adds testData to all current administrations, and sets the value to false if it does not already have a value
  3. Modify CreateAdministration.vue to set testData to false by default, if not provided (ADDRESSED IN FIREKIT PR)
  4. Check for LEVANTE?
    • [ ] Bugfix (non-breaking change which fixes an issue)
    • [x] New feature (non-breaking change which adds functionality)
    • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • [ ] Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
    • [ ] Documentation Update
    • [ ] Tests (new or updated tests)
    • [ ] Style (changes to code styling)
    • [ ] CI (continuous integration changes)
    • [ ] Repository Maintenance
    • [ ] Other (please describe below)

    Checklist

    • [x] I have read the guidelines for contributing.
    • [x] The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
    • [x] Linting checks pass with my changes.
    • [x] Any existing unit tests pass with my changes.
    • [x] Any existing end-to-end tests pass with my changes.
    • [ ] I have added tests that prove my fix is effective or that my feature works.
    • [ ] If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
    • [ ] I have added JSDoc comments as appropriate.
    • [ ] I have added the necessary documentation to the roar-docs repository.
    • [ ] I have shared this PR on the roar-pr-reviews channel (if I have access)
    • [ ] I have linked relevant issues (if any)

    Justification of missing checklist items

    Further comments

github-actions[bot] commented 1 month ago

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.94% 73 / 7685
🔵 Statements 0.9% 74 / 8181
🔵 Functions 0.68% 14 / 2040
🔵 Branches 0.46% 20 / 4297
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/helpers/query/administrations.js 0% 0% 0% 0% 10-15, 11, 14, 18-140, 29-33, 35-64, 36-39, 37-38, 41-63, 42-44, 46-62, 66-72, 76-110, 77-83, 87-93, 97-109, 98-108, 104, 113-123, 114-122, 125-137, 126-136, 139, 142-167, 143-164, 146-148, 150-161, 152-157, 153-156, 155, 158, 163, 166, 169-213, 170-212, 172-181, 180, 183, 185-206, 187-205, 188-196, 189-195, 198-204, 200-202, 201, 208-210, 210-211, 215-263, 217-242, 218-227, 226, 228-241, 245-249, 247, 249, 251-252, 254-260, 255, 255-259, 262, 265-327, 274-326, 276-288, 287, 290, 292-313, 294-312, 295-303, 296-302, 305-311, 307-309, 308, 315-324, 319, 321, 321-322, 322-323, 325
src/pages/HomeAdministrator.vue 0% 0% 0% 0% 134-136, 138-139, 141, 144-147, 145, 145-146, 149-151, 150, 150, 153-155, 154, 154, 157-159, 161, 161-162, 162-163, 163-166, 165, 173-197, 174, 176-194, 177-192, 180-188, 193, 196, 199-206, 201, 212-241, 215-223, 229-231, 230, 233-239, 234, 236-238, 237, 243, 245-251, 246-248, 250, 253-335, 337-341, 338-340, 343-351, 344-350, 345, 347-349, 348, 353-357, 354-356, 355, 359-378, 360-363, 365-370, 367, 369, 371-375, 372, 374, 377, 2-3, 5-6, 14-15, 17, 20-22, 41-42, 85, 118, 18, 25, 44, 49
Generated in workflow #180
github-actions[bot] commented 1 month ago

Visit the preview URL for this PR (updated for commit 42033be):

https://roar-staging--pr749-query-test-admins-vbz8ncnt.web.app

(expires Wed, 11 Sep 2024 21:49:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

cypress[bot] commented 1 month ago

roar-dashboard-e2e    Run #5675

Run Properties:  status check passed Passed #5675  •  git commit 42033be877: Tests for PR 749 "Toggle Test Admins in Super Admin View" from commit "42033be87...
Project roar-dashboard-e2e
Branch Review query-test-admins
Run status status check passed Passed #5675
Run duration 02m 17s
Commit git commit 42033be877: Tests for PR 749 "Toggle Test Admins in Super Admin View" from commit "42033be87...
Committer emily-ejag
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 32
View all changes introduced in this branch ↗︎
Emily-ejag commented 1 month ago

Cool!

Emily-ejag commented 1 month ago

LGTM, but I don't know why the tests are failing tho.

richford commented 1 month ago

Approved! Can you either rebase on main or update the roar-firebase-functions submodule to that upstream main?