Closed ksmontville closed 1 month ago
Status | Category | Percentage | Covered / Total |
---|---|---|---|
🔵 | Lines | 0.94% | 73 / 7685 |
🔵 | Statements | 0.9% | 74 / 8181 |
🔵 | Functions | 0.68% | 14 / 2040 |
🔵 | Branches | 0.46% | 20 / 4297 |
Visit the preview URL for this PR (updated for commit 42033be):
https://roar-staging--pr749-query-test-admins-vbz8ncnt.web.app
(expires Wed, 11 Sep 2024 21:49:33 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460
Passed #5675
•
42033be877: Tests for PR 749 "Toggle Test Admins in Super Admin View" from commit "42033be87...
Project |
roar-dashboard-e2e
|
Branch Review |
query-test-admins
|
Run status |
Passed #5675
|
Run duration | 02m 17s |
Commit |
42033be877: Tests for PR 749 "Toggle Test Admins in Super Admin View" from commit "42033be87...
|
Committer | emily-ejag |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
32
|
View all changes introduced in this branch ↗︎ |
Cool!
LGTM, but I don't know why the tests are failing tho.
Approved! Can you either rebase on main or update the roar-firebase-functions submodule to that upstream main?
Proposed changes
This PR adds a toggle to remove test administrations from the super admin view. It also fixes an issue with the
checkLegalDoc.cy.js
Cypress test.TODO:
CreateAdministrations.vue
to ensure that all future administrations will have they key-value pairtestData: false
unless explicitly set totrue
in administration creation (DONE IN A SEPARATE PR)Firebase Functions PR: https://github.com/yeatmanlab/roar-firebase-functions/pull/267 (MERGED)
Concerns:
testData
field, which means admins that are not intended to be test data will still be filtered outtestData
to all current administrations, and sets the value to false if it does not already have a valueCreateAdministration.vue
to set testData to false by default, if not provided (ADDRESSED IN FIREKIT PR)Checklist
Justification of missing checklist items
Further comments