Contrast text color on Score Report blue bubbles

Emily-ejag commented 1 month ago

Proposed changes

Types of changes

What types of changes does this pull request introduce?

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
[ ] Documentation Update
[ ] Tests (new or updated tests)
[ ] Style (changes to code styling)
[ ] CI (continuous integration changes)
[ ] Repository Maintenance
[ ] Other (please describe below)

Checklist

[x] I have read the guidelines for contributing.
[x] The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
[x] Linting checks pass with my changes.
[x] Any existing unit tests pass with my changes.
[x] Any existing end-to-end tests pass with my changes.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
[ ] I have added JSDoc comments as appropriate.
[ ] I have added the necessary documentation to the roar-docs repository.
[x] I have shared this PR on the roar-pr-reviews channel (if I have access)
[ ] I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

github-actions[bot] commented 1 month ago

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	0.96%	73 / 7549
🔵	Statements	0.92%	74 / 8039
🔵	Functions	0.69%	14 / 2006
🔵	Branches	0.47%	20 / 4215

File Coverage

File	Stmts	% Branch	% Funcs	% Lines	Uncovered Lines
Changed Files
src/components/reports/TableScoreTag.vue	0%	0%	0%	0%	51-63, 52-53, 55-61, 57, 59-61, 60, 62, 67-70, 68-69, 74-103, 80-102, 81-102, 85-91, 86-87, 89-90, 92-102, 93-102, 97, 99-101, 106, 110-115, 118-139, 119-136, 121, 121-124, 123, 125, 125-126, 128-130, 129, 131-134, 133, 135, 138

Generated in workflow #43

github-actions[bot] commented 1 month ago

Visit the preview URL for this PR (updated for commit f04a928):

https://roar-staging--pr750-enh-contrast-score-r-wpj9zl7g.web.app

_{(expires Wed, 28 Aug 2024 16:29:53 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460}

cypress[bot] commented 1 month ago

Test summary

26 • 0 • 0 • 0 • 0

Run details


Project	roar-dashboard-e2e
Status	Passed
Commit	f04a9287ea
Started	Aug 21, 2024 4:29 PM
Ended	Aug 21, 2024 4:34 PM
Duration	04:41 💡
OS	Linux Ubuntu -
Browser	Edge 127

View run in Cypress Cloud ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

richford commented 1 month ago

Approved, but please resolve the merge conflicts in package-lock.json

yeatmanlab / roar-dashboard