search

yeatmanlab / roar-dashboard

A dashboard to administer ROAR assessments
https://roar.education
Other
4 stars 4 forks source link

fix/Edit Administrations #754

Closed ksmontville closed 1 month ago

ksmontville commented 1 month ago

Proposed changes

Implement watchers and invalidate queries in order to properly handle administration edits.

Firekit PR: https://github.com/yeatmanlab/roar-firekit/pull/140

Types of changes

What types of changes does this pull request introduce?

Checklist

Justification of missing checklist items

Further comments

github-actions[bot] commented 1 month ago

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.95% 73 / 7623
🔵 Statements 0.91% 74 / 8117
🔵 Functions 0.68% 14 / 2029
🔵 Branches 0.46% 20 / 4263
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/ConsentPicker.vue 0% 0% 0% 0% 283, 287-304, 306-316, 318-333, 335-340, 343-346, 344-345, 347-350, 348-349, 351-362, 365-366, 368-381, 369-380, 371-372, 374-379, 383-396, 384, 387-394, 388-393, 399-422, 407, 410-422, 414, 416, 418, 420-421, 425-431, 433-445, 434-435, 437-443, 438-442, 439-442, 441, 444, 449-453, 450, 452, 454-456, 460-463, 462, 467-470, 469, 474-484, 475-481, 476-480, 477-480, 479, 482-483, 488-508, 489-497, 492-496, 493-495, 499-507, 500-506, 501-505, 502-504, 512-532, 515-529, 516-528, 521-528, 527, 530-531, 536, 538-562, 539-561, 541-542, 546-561, 549, 552-561, 555-556, 556-560, 558-559, 566-568, 567, 571-577, 572-576, 573, 575, 579-582, 580-581, 584-587, 585-586, 589-596, 590-595, 591, 593-594, 3-5, 15, 17, 27, 31, 33-34, 37, 39, 41, 43, 51-52, 57, 65, 74-75, 101-102, 128-129, 147-151, 153, 156-157, 159, 166, 175, 185-188, 190, 193-194, 196, 203-204, 206-209, 209-212, 212-215, 215, 218, 228, 231, 233-236, 236-239, 239-242, 242, 245, 255, 7, 19, 32, 45, 77, 104, 131, 152, 158, 168, 177, 189, 195, 222, 249, 263
src/components/CreateAdministration.vue 0% 0% 0% 0% 196-202, 204, 206, 210-216, 211-213, 212, 215, 218-223, 219-221, 220, 222, 225-231, 226-228, 227, 230, 236-243, 238-242, 239-241, 245-251, 247, 257-265, 267-269, 268, 271-273, 272, 276-285, 277-284, 279-283, 287-289, 288, 292-301, 293-300, 295-299, 303-305, 304, 308-317, 309-316, 311-315, 319-321, 320, 324-333, 325-332, 327-331, 335-337, 336, 340-349, 341-348, 343-347, 351-353, 352, 355-359, 356-358, 357, 361-365, 362-364, 363, 367-373, 369, 375-381, 377, 383-389, 385, 391-397, 393, 399-405, 401, 407-413, 409, 418, 420-423, 425-441, 443-451, 453, 455-460, 456-458, 457, 459, 462-467, 463-465, 464, 466, 472-480, 473-479, 482-486, 483-485, 484, 491-493, 495-497, 496, 499-501, 500, 503-516, 504-515, 505-509, 512-514, 518-522, 519, 519-520, 520-521, 524-529, 525, 525-527, 527-528, 528, 531-534, 532, 532-533, 539-542, 541, 541, 544-547, 546, 546, 549-630, 550-629, 554-563, 555-562, 565-626, 567-573, 568-572, 575-616, 577-595, 595, 597-612, 600-607, 610-611, 614-615, 618-625, 628, 636-639, 637, 637-638, 641-643, 642, 642, 645-649, 646, 646, 648, 651-656, 652-655, 654, 658-683, 659-682, 660-673, 666-668, 668-672, 671, 674-677, 679-681, 680, 686-695, 687-694, 689-692, 691, 693, 697-706, 698-705, 700-703, 702, 704, 708-717, 709-716, 711-714, 713, 715, 719-726, 720-725, 722-723, 723-724, 728-737, 729-736, 731-734, 733, 735, 2-6, 8, 11, 15-18, 25, 34-35, 42, 51-53, 65, 71-72, 84, 96, 99-101, 104, 121-125, 133, 142, 148, 153-154, 21, 38, 55, 74, 92, 127, 135, 149
src/components/OrgPicker.vue 0% 0% 0% 0% 101-103, 105-106, 108, 124-130, 133-135, 134, 138-148, 139, 141-145, 150-156, 152, 158, 158-159, 159, 161-188, 162-167, 169, 169, 171-176, 173-175, 177-180, 178-179, 181-183, 182, 184-186, 185, 187, 190-195, 191-193, 192, 194, 197-202, 198-200, 199, 201, 204-207, 206, 209, 209, 211-217, 213, 219-221, 220, 223-229, 225, 231-245, 234-241, 247-249, 248, 248, 251-253, 252, 252, 256-259, 257, 257-258, 261-263, 262, 262, 265-267, 266, 266, 269-271, 270, 273-275, 274, 277, 279-281, 280, 2-3, 7, 12, 25, 29, 42, 46, 57, 59, 68, 5, 15, 32, 48, 80
src/components/TaskPicker.vue 0% 0% 0% 0% 152, 154, 169, 171-180, 172-179, 173-178, 182-196, 183, 185, 188-194, 189, 189-192, 191, 193, 198-209, 199-205, 200-204, 201, 203, 206-207, 211-212, 214, 216-221, 217-219, 218, 218, 220, 224, 227-229, 231-247, 232-245, 235-243, 236-242, 241-242, 244, 246, 250-251, 254, 256-262, 257-261, 258, 260, 265-271, 267, 273-290, 275, 277-289, 279-288, 280-285, 287, 292-300, 294-295, 295-299, 297-299, 302-308, 305, 311-313, 312, 312, 314-334, 316-317, 317-333, 321, 321-329, 323-328, 330, 332, 335-341, 336, 336-337, 337-340, 342-348, 343, 343-344, 344-347, 4-5, 10, 12-14, 23, 28, 95, 97, 99, 6, 15, 36, 58, 69, 73, 103
src/pages/HomeParticipant.vue 0% 0% 0% 0% 108-112, 114, 116-120, 118, 118-119, 122-123, 125-127, 126, 126, 129-131, 130, 130, 133-134, 140-146, 142, 152-160, 154, 162, 162, 162-163, 163, 169-184, 172-180, 174-178, 186-188, 187, 187, 191-196, 198-206, 200-204, 201-203, 205, 208-210, 212-215, 217, 219-221, 223-243, 224-230, 227-229, 228, 232-238, 233-237, 234-236, 239-243, 240-242, 247-257, 253-254, 256, 260, 260, 260, 266-280, 269-275, 270-273, 282-288, 284, 290-292, 291, 294-296, 295, 298-301, 299, 299-300, 303-307, 305-306, 311-353, 312-351, 313-337, 316-318, 323, 323-334, 339-348, 341-347, 342-346, 343-345, 344, 350, 352, 355-357, 356, 356, 359-361, 360, 360, 364-373, 365-372, 368, 376-378, 377, 381-383, 382, 382, 386-393, 387-389, 388, 390-392, 395-411, 398-400, 399, 401-402, 402, 405-408, 407, 12, 30-31, 50, 55, 70, 72, 18, 33-34, 43
Generated in workflow #90
github-actions[bot] commented 1 month ago

Visit the preview URL for this PR (updated for commit 50402df):

https://roar-staging--pr754-fix-edit-administrat-ov76i5mn.web.app

(expires Fri, 30 Aug 2024 22:32:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

cypress[bot] commented 1 month ago

roar-dashboard-e2e    Run #5340

Run Properties:  status check passed Passed #5340  •  git commit 50402df61d: Tests for PR 754 "fix/Edit Administrations" from commit "50402df61d348de01c9a52f...
Project roar-dashboard-e2e
Branch Review fix/edit-administrations
Run status status check passed Passed #5340
Run duration 04m 58s
Commit git commit 50402df61d: Tests for PR 754 "fix/Edit Administrations" from commit "50402df61d348de01c9a52f...
Committer Kyle
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 26
View all changes introduced in this branch ↗︎
Emily-ejag commented 1 month ago

This is working so good! thanks Kyle. there is just a tiny thing that is not working and is when selecting This administration does not require consent or assent forms save and then try to edit, that particular selection is not showing, the rest is working fine.

ksmontville commented 1 month ago

This is working so good! thanks Kyle. there is just a tiny thing that is not working and is when selecting This administration does not require consent or assent forms save and then try to edit, that particular selection is not showing, the rest is working fine.

I fixed the checkbox issue and blank fields issue, do you mind taking another look?

Emily-ejag commented 1 month ago

It is awesome!! I think the only mark as test is not being pulled. But the rest is smooth like butter :)

image
ksmontville commented 1 month ago

It is awesome!! I think the only mark as test is not being pulled. But the rest is smooth like butter :) image

Just fixed this issue on the front end.

Also needs a fix to Firekit on the backend to properly save the testData key: https://github.com/yeatmanlab/roar-firekit/pull/140