Migrate Offline Settings to composable TanStack queries

maximilianoertel commented 1 month ago

Proposed changes

This PR migrates the Offline Settings page to use new composable TanStack queries and mutations. Additionally, this PR improves minor rendering issues such as a broken loading spinner and redundant v-if/else conditions.

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
[ ] Documentation Update
[ ] Tests (new or updated tests)
[ ] Style (changes to code styling)
[ ] CI (continuous integration changes)
[ ] Repository Maintenance
[ ] Other (please describe below)

Checklist

[x] I have read the guidelines for contributing.
[x] The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
[x] Linting checks pass with my changes.
[x] Any existing unit tests pass with my changes.
[x] Any existing end-to-end tests pass with my changes.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
[x] I have added JSDoc comments as appropriate.
[ ] I have added the necessary documentation to the roar-docs repository.
[x] I have shared this PR on the roar-pr-reviews channel (if I have access)
[ ] I have linked relevant issues (if any)

Justification of missing checklist items

n/a

Further comments

n/a

Ref https://github.com/yeatmanlab/roar/issues/318

github-actions[bot] commented 1 month ago

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	2.15%	163 / 7578
🔵	Statements	2.02%	169 / 8332
🔵	Functions	2.1%	39 / 1850
🔵	Branches	0.99%	45 / 4528

File Coverage

File	Stmts	% Branch	% Funcs	% Lines	Uncovered Lines
Changed Files
src/components/views/OfflineSettings.vue	0%	0%	0%	0%	173-174, 176-178, 180, 183-186, 184, 184-185, 188, 190-192, 194, 196-198, 200-202, 204-212, 205, 205-211, 207-210, 214-217, 219-228, 221-222, 225-227, 230-232, 231, 234-247, 235-246, 236-242, 244-245, 249-262, 250-261, 251-257, 259-260, 264-266, 265, 265, 268-270, 269, 269, 272-274, 273, 273, 276-279, 277, 277-278, 281-313, 282-286, 288, 290-312, 297, 300-306, 309, 9, 1, 13, 30, 37, 55, 74, 82, 91, 111, 130, 147-148, 1-25, 1-39, 72, 1-95, 128
src/composables/mutations/useUpdateUserMutation.js	100%	100%	100%	100%
src/constants/mutationKeys.js	100%	100%	100%	100%

Generated in workflow #255

github-actions[bot] commented 1 month ago

Visit the preview URL for this PR (updated for commit 4420b8e):

https://roar-staging--pr777-ref-318-query-compos-s1w2d8wl.web.app

_{(expires Tue, 17 Sep 2024 09:02:42 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460}

cypress[bot] commented 1 month ago

roar-dashboard-e2e Run #6056

Run Properties: Passed #6056 • 4420b8e78c: E2E Tests for PR 777 "Migrate Offline Settings to composable TanStack queries" f...

Project	`roar-dashboard-e2e`
Branch Review	`ref/318/query-composables-offline-settings`
Run status	`Passed #6056`
Run duration	`05m 57s`
Commit	`4420b8e78c: E2E Tests for PR 777 "Migrate Offline Settings to composable TanStack queries" f...`
Committer	`Maximilian Oertel`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`1`
Pending	`0`
Skipped	`0`
Passing	`32`
View all changes introduced in this branch ↗︎

yeatmanlab / roar-dashboard