yeatmanlab / roar-dashboard

A dashboard to administer ROAR assessments
https://roar.education
Other
4 stars 4 forks source link

Fix test Open Admins #779

Closed Emily-ejag closed 1 month ago

Emily-ejag commented 1 month ago

Proposed changes

The page refreshes when It picks the administration again after a refresh. So the solution we got with @ksmontville is to go back to switching to optional assignments.

Also reduced at least 1 min of sre and sre-es, since the game goes by time, we don't need to run the loop 80 times, I reduced it to 50. (33 is the max I have seen it uses {left-arrow} {write-arrow}, but kept it on 50 just in case)

Types of changes

What types of changes does this pull request introduce?

Checklist

Justification of missing checklist items

We need this for deployment

Further comments

github-actions[bot] commented 1 month ago

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.94% 73 / 7685
🔵 Statements 0.9% 74 / 8181
🔵 Functions 0.68% 14 / 2040
🔵 Branches 0.46% 20 / 4297
File CoverageNo changed files found.
Generated in workflow #190
github-actions[bot] commented 1 month ago

Visit the preview URL for this PR (updated for commit be2d1f0):

https://roar-staging--pr779-fix-roam-test-all-op-5itic4aq.web.app

(expires Thu, 12 Sep 2024 16:08:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

ROAR
cypress[bot] commented 1 month ago

roar-dashboard-e2e    Run #5711

Run Properties:  status check passed Passed #5711  •  git commit be2d1f03e2: Tests for PR 779 "WIP: Fix test Open Admins" from commit "be2d1f03e24dc39ad6f302...
Project roar-dashboard-e2e
Branch Review fix/roam-test-all-open-admins
Run status status check passed Passed #5711
Run duration 02m 19s
Commit git commit be2d1f03e2: Tests for PR 779 "WIP: Fix test Open Admins" from commit "be2d1f03e24dc39ad6f302...
Committer emily-ejag
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 32
View all changes introduced in this branch ↗︎