Add fallback values before calling the forEach method

richford commented 1 month ago

Proposed changes

This PR adds a fallback (empty array) value before each of the forEach methods in CardAdministration.vue. This resolves an issue where expanded classes were freezing on each administration card.

Types of changes

What types of changes does this pull request introduce?

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
[ ] Documentation Update
[ ] Tests (new or updated tests)
[ ] Style (changes to code styling)
[ ] CI (continuous integration changes)
[ ] Repository Maintenance
[ ] Other (please describe below)

Checklist

[x] I have read the guidelines for contributing.
[x] The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
[x] Linting checks pass with my changes.
[x] Any existing unit tests pass with my changes.
[x] Any existing end-to-end tests pass with my changes.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
[x] I have added JSDoc comments as appropriate.
[x] I have added the necessary documentation to the roar-docs repository.
[x] I have shared this PR on the roar-pr-reviews channel (if I have access)
[x] I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

github-actions[bot] commented 1 month ago

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	0.96%	73 / 7564
🔵	Statements	0.89%	74 / 8311
🔵	Functions	0.75%	14 / 1849
🔵	Branches	0.44%	20 / 4535

File Coverage

File	Stmts	% Branch	% Funcs	% Lines	Uncovered Lines
Changed Files
src/components/CardAdministration.vue	0%	0%	0%	0%	166, 168-169, 171, 183-184, 186-219, 191-209, 196-204, 197-203, 207, 216, 221-225, 222-224, 223, 227-231, 228, 230, 233, 233-234, 234, 236-238, 237, 237, 240-242, 241, 245, 245, 248-249, 251-252, 254-259, 255-257, 256, 258, 261-266, 262-264, 263, 265, 268-271, 269-270, 273-275, 274, 277-283, 286-411, 287-290, 289, 289, 292-296, 294, 294, 298, 300, 302-325, 303-323, 315-323, 316-322, 324, 327, 327, 329-330, 330, 332, 334-336, 335, 338-340, 339, 342, 342-345, 344, 347-350, 352, 354-371, 356, 358, 358, 360-368, 373, 373-374, 376-393, 377-378, 378-392, 380-389, 381-386, 388, 391, 395-396, 396-397, 397, 399-408, 401-407, 402-406, 403, 403-404, 404-405, 410, 413-419, 415, 421-423, 422, 425-428, 427, 430-432, 431, 431, 434-517, 436-516, 437, 439, 439-440, 440, 442, 444, 448-454, 456-472, 458, 460, 460, 462-469, 474, 478-499, 480-496, 481-491, 486-488, 487, 489, 492, 494-496, 495, 498, 502-512, 503-511, 504-510, 505-509, 506, 506-507, 507-508, 514-515, 519-520, 522-533, 522-533, 535-556, 536-537, 539-540, 542-555, 558-563, 559-562, 560-561, 2, 7-9, 27, 29, 33, 1, 97, 42

Generated in workflow #306

cypress[bot] commented 1 month ago

roar-dashboard-e2e Run #6362

Run Properties: Passed #6362 • 337e3489a4: E2E Tests for PR 793 "Add fallback values before calling the forEach method" fro...

Project	`roar-dashboard-e2e`
Branch Review	`enh/for-each-fallback`
Run status	`Passed #6362`
Run duration	`08m 32s`
Commit	`337e3489a4: E2E Tests for PR 793 "Add fallback values before calling the forEach method" fro...`
Committer	`Adam Richie-Halford`
View all properties for this run ↗︎