CU-8689ubqge fix/App Public Names in Reports

ksmontville commented 4 weeks ago

Proposed changes

Fix for taskId showing in place of publicName in reports.

Major Changes:

New function to setup tasksDictionary within authstore, rather than relying on firekit method. The logic mimics the logic found within the firekit method. This is because the tasksDictionary object was often being accessed before the firekit method could populate it.
Move authStore.updateTasksDictionary() to onUpdated() hook, helping to ensure that tasksDictionary is defined when the DOM or auth state changes.
Use standard imports for HomeAdministrator.vue, HomeParticipant.vue, and ConsentModal.vue within HomeSelector.vue instead of dynamic imports. The dynamic imports were causing issues with component rendering when re-directing from Clever sign in. There is likely a better fix for this in the future.
Added wait time to some Cypress tests.
Added some network tests for some partner admin tests.

What types of changes does this pull request introduce?

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
[ ] Documentation Update
[ ] Tests (new or updated tests)
[ ] Style (changes to code styling)
[ ] CI (continuous integration changes)
[ ] Repository Maintenance
[ ] Other (please describe below)

[x] I have read the guidelines for contributing.
[x] The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
[x] Linting checks pass with my changes.
[x] Any existing unit tests pass with my changes.
[x] Any existing end-to-end tests pass with my changes.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
[x] I have added JSDoc comments as appropriate.
[ ] I have added the necessary documentation to the roar-docs repository.
[x] I have shared this PR on the roar-pr-reviews channel (if I have access)
[x] I have linked relevant issues (if any)

richford commented 4 weeks ago

github-actions[bot] commented 4 weeks ago

Status	Category	Percentage	Covered / Total
🔵	Lines	0.96%	73 / 7564
🔵	Statements	0.89%	74 / 8311
🔵	Functions	0.75%	14 / 1851
🔵	Branches	0.44%	20 / 4538

File Coverage

File	Stmts	% Branch	% Funcs	% Lines	Uncovered Lines
Changed Files
src/App.vue	0%	0%	0%	0%	32, 32, 38-39, 41-42, 44-48, 45-47, 50, 50, 52, 54-80, 82-84, 83, 86-98, 87-96, 90-95, 91-94, 97
src/pages/CleverLanding.vue	0%	0%	0%	0%	16-18, 23-54, 24-49, 30-40, 33-37, 39, 41-49, 42-46, 48, 51-53, 52, 57-59, 2
src/pages/HomeSelector.vue	0%	0%	0%	0%	37-39, 41-42, 44-50, 45-50, 48-49, 52-53, 55, 57-60, 58, 58-59, 62-64, 63, 63, 66-72, 68, 74-80, 76, 82, 82, 84-88, 85, 85-86, 86-87, 90-96, 91-95, 92, 94, 97-99, 102-105, 103-104, 109, 113-116, 115, 119-136, 120-127, 124-126, 129-130, 130, 132-135, 133-134, 140-142, 146-150, 147-149, 148, 152-161, 153-156, 154-155, 157, 157-160, 159, 1, 3, 5
src/store/auth.js	0%	0%	0%	0%	10-245, 11-244, 15-36, 40, 43, 46, 49, 52, 55, 58, 61, 61-62, 62-63, 65, 69-70, 73-80, 74-79, 75-76, 78, 81-88, 82-87, 83-84, 86, 91-93, 92, 96, 99-107, 100-104, 102-103, 106, 110, 113, 116-124, 117-123, 121-122, 127-132, 128-131, 130, 135-139, 136-138, 137, 142-144, 143, 147-150, 149, 153-156, 155, 159, 162-163, 166-167, 170-174, 172-173, 175-184, 176-183, 178-182, 179, 181, 187, 190-192, 195-218, 196-215, 197-206, 208-211, 213-214, 217, 221-228, 222-224, 223, 226-227, 231, 236, 247-249, 248

Generated in workflow #430

github-actions[bot] commented 4 weeks ago

Visit the preview URL for this PR (updated for commit 2bc49d2):

_{(expires Mon, 30 Sep 2024 18:44:31 GMT)}

_{Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460}

cypress[bot] commented 4 weeks ago

Run Properties: Passed #7087 • 2bc49d2bfb: E2E Tests for PR 821 "CU-8689ubqge fix/App Public Names in Reports" from commit ...

Project	`roar-dashboard-e2e`
Branch Review	`fix/app-public-names`
Run status	`Passed #7087`
Run duration	`03m 30s`
Commit	`2bc49d2bfb: E2E Tests for PR 821 "CU-8689ubqge fix/App Public Names in Reports" from commit ...`
Committer	`Kyle`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`13`
View all changes introduced in this branch ↗︎

sentry-io[bot] commented 3 weeks ago

This pull request was deployed and Sentry observed the following issues:

‼️ AxiosError: Request failed with status code 401 <object>.actions.updateTasksDictionary(src/stor... View Issue
‼️ AxiosError: Request failed with status code 401 <object>.actions.updateTasksDictionary(src/stor... View Issue
‼️ TypeError: can't access property "indexOf", r is undefined <object>.actions.updateTasksDictionary(src/stor... View Issue
‼️ TypeError: can't access property "indexOf", r is undefined <object>.actions.updateTasksDictionary(src/stor... View Issue
‼️ Error: User claims document does not exist. initNewFirekit(src/firebaseInit) View Issue

_{Did you find this useful? React with a 👍 or 👎}