yeatmanlab / roar-dashboard

A dashboard to administer ROAR assessments
https://roar.education
Other
4 stars 4 forks source link

Replace `uid` with `roarUid` on ClassLink landing page #836

Closed maximilianoertel closed 2 weeks ago

maximilianoertel commented 2 weeks ago

Proposed changes

As discussed with @richford, this PR updates the user type check on the ClassLink landing page to use the roarUid instead of uid. As this function is identical on both this and the Clever page, a separate PR will be opened to refactor the function into a reusable helper.

Types of changes

Checklist

Justification of missing checklist items

n/a

Further comments

n/a

github-actions[bot] commented 2 weeks ago

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.97% 73 / 7476
🔵 Statements 0.9% 74 / 8211
🔵 Functions 0.76% 14 / 1819
🔵 Branches 0.44% 20 / 4496
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/pages/ClassLinkLanding.vue 0% 0% 0% 0% 16-18, 23-54, 24-49, 30-40, 33-37, 39, 41-49, 42-46, 48, 51-53, 52, 57-61, 2
src/pages/CleverLanding.vue 0% 0% 0% 0% 16-18, 23-54, 24-49, 30-40, 33-37, 39, 41-49, 42-46, 48, 51-53, 52, 57-59, 2
Generated in workflow #495
github-actions[bot] commented 2 weeks ago

Visit the preview URL for this PR (updated for commit 68c34ca):

https://roar-staging--pr836-bug-classlink-uid-re-6f2jnvqu.web.app

(expires Fri, 04 Oct 2024 20:20:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

cypress[bot] commented 2 weeks ago

roar-dashboard-e2e    Run #7455

Run Properties:  status check failed Failed #7455  •  git commit 68c34cac41: E2E Tests for PR 836 "Replace `uid` with `roarUid` on ClassLink landing page" fr...
Project roar-dashboard-e2e
Branch Review bug/classlink-uid-ref
Run status status check failed Failed #7455
Run duration 05m 18s
Commit git commit 68c34cac41: E2E Tests for PR 836 "Replace `uid` with `roarUid` on ClassLink landing page" fr...
Committer Maximilian Oertel
View all properties for this run ↗︎

Test results
Tests that failed  Failures 7
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 6
View all changes introduced in this branch ↗︎


Tests for review

Failed  viewProgressReport.cy.js • 1 failed test View Output
Test Artifacts
The partner admin can view progress reports for a given administration. > Selects an administration and views its progress report Test Replay Screenshots
Failed  viewScoreReports.spec.cy.js • 1 failed test View Output
Test Artifacts
The partner admin can view score reports for a given administration. > Selects an administration and views its score report. Test Replay Screenshots
Failed  viewIndividualReport.cy.js • 1 failed test View Output
Test Artifacts
The partner admin can view individual score reports for a given administration. > Selects an administration and views a student's individual score report Test Replay Screenshots
Failed  exportSelectedScoreReport.cy.js • 1 failed test View Output
Test Artifacts
The partner admin can select and export progress reports for a given administration. > Selects an administration and views its progress report Test Replay Screenshots
Failed  exportWholeScoreReport.cy.js • 1 failed test View Output
Test Artifacts
The partner admin can select and export progress reports for a given administration. > Selects an administration and views its progress report Test Replay Screenshots

The first 5 failed specs are shown, see all 7 specs in Cypress Cloud.

sentry-io[bot] commented 1 week ago

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎