yeatmanlab / roar-dashboard

A dashboard to administer ROAR assessments
https://roar.education
Other
4 stars 4 forks source link

Migrate administration deletion to TanStack mutation #841

Closed maximilianoertel closed 1 week ago

maximilianoertel commented 2 weeks ago

Proposed changes

This PR migrates the existing administration deletion method to use a new useAdministrationDeletionMutation composable in order to invalidate queries upon success.

Types of changes

Checklist

Justification of missing checklist items

n/a

Further comments

n/a

Ref https://github.com/yeatmanlab/roar/issues/318

github-actions[bot] commented 2 weeks ago

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 5.09% 392 / 7690
🔵 Statements 4.98% 423 / 8479
🔵 Functions 6.15% 116 / 1885
🔵 Branches 2.46% 114 / 4619
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/CardAdministration.vue 0% 0% 0% 0% 174, 176, 188-189, 191, 193-230, 198-220, 203, 205-210, 213-218, 227, 232-236, 233-235, 234, 238-242, 239, 241, 244, 244-245, 245, 247-249, 248, 248, 251-253, 252, 256, 256, 259-260, 262-263, 265-270, 266-268, 267, 269, 272-277, 273-275, 274, 276, 279-282, 280-281, 284-286, 285, 288, 290-292, 294-296, 295, 298-301, 300, 303-305, 304, 304, 307-390, 309-389, 310, 312, 312-313, 313, 315, 317, 321-327, 329-345, 331, 333, 333, 335-342, 347, 351-372, 353-369, 354-364, 359-361, 360, 362, 365, 367-369, 368, 371, 375-385, 376-384, 377-383, 378-382, 379, 379-380, 380-381, 387-388, 392-393, 395-406, 395-406, 408-429, 409-410, 412-413, 415-428, 431-436, 432-435, 433-434, 2, 7-9, 28, 30, 35, 1, 104, 45
src/composables/mutations/useDeleteAdministrationMutation.js 100% 100% 100% 100%
src/constants/mutationKeys.js 100% 100% 100% 100%
Generated in workflow #552 for commit 9daa638 by the Vitest Coverage Report Action
github-actions[bot] commented 2 weeks ago

Visit the preview URL for this PR (updated for commit 9daa638):

https://roar-staging--pr841-ref-318-query-compos-sig4n31d.web.app

(expires Wed, 09 Oct 2024 22:32:52 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

cypress[bot] commented 1 week ago

roar-dashboard-e2e    Run #7750

Run Properties:  status check passed Passed #7750  •  git commit 9daa638763: E2E Tests for PR 841 "Migrate administration deletion to TanStack mutation" from...
Project roar-dashboard-e2e
Branch Review ref/318/query-composables-delete-administration
Run status status check passed Passed #7750
Run duration 04m 03s
Commit git commit 9daa638763: E2E Tests for PR 841 "Migrate administration deletion to TanStack mutation" from...
Committer Maximilian Oertel
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 13
View all changes introduced in this branch ↗︎