yeatmanlab / roar-dashboard

A dashboard to administer ROAR assessments
https://roar.education
Other
4 stars 4 forks source link

Suggested changes for parent sign up e2e test #857

Closed ksmontville closed 1 week ago

ksmontville commented 1 week ago

Proposed changes

Suggested changes to parent sign up code end-to-end test.

Suggestions:

  1. Test only one organization (district)
  2. Circumvent the Window api (difficulties with Cypress) and just grab the activation code value from the input text component
  3. No need to test clipboard functionality within this Cypress test (that could be a separate unit test)
  4. General refactoring
  5. Necessary secrets entered into GitHub repo
    • [ ] Bugfix (non-breaking change which fixes an issue)
    • [ ] New feature (non-breaking change which adds functionality)
    • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • [ ] Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
    • [ ] Documentation Update
    • [ ] Tests (new or updated tests)
    • [ ] Style (changes to code styling)
    • [ ] CI (continuous integration changes)
    • [ ] Repository Maintenance
    • [ ] Other (please describe below)

    Checklist

    • [ ] I have read the guidelines for contributing.
    • [ ] The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
    • [ ] Linting checks pass with my changes.
    • [ ] Any existing unit tests pass with my changes.
    • [ ] Any existing end-to-end tests pass with my changes.
    • [ ] I have added tests that prove my fix is effective or that my feature works.
    • [ ] If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
    • [ ] I have added JSDoc comments as appropriate.
    • [ ] I have added the necessary documentation to the roar-docs repository.
    • [ ] I have shared this PR on the roar-pr-reviews channel (if I have access)
    • [ ] I have linked relevant issues (if any)

    Justification of missing checklist items

    Further comments

github-actions[bot] commented 1 week ago

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.97% 73 / 7454
🔵 Statements 0.9% 74 / 8187
🔵 Functions 0.77% 14 / 1807
🔵 Branches 0.44% 20 / 4505
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/ListOrgs.vue 0% 0% 0% 0% 171-182, 184-189, 185-187, 186, 188, 191-196, 192-194, 193, 195, 199-200, 202-208, 204, 210, 210-211, 211, 213-240, 214-219, 221, 221, 223-228, 225-227, 229-232, 230-231, 233-235, 234, 236-238, 237, 239, 242-245, 244, 247, 247, 249-255, 251, 258-275, 261-266, 269-274, 278-280, 279, 282-288, 284, 294-310, 297-306, 312-322, 313-321, 340-403, 341-402, 343, 345-353, 346-352, 355-363, 356-362, 366, 368-383, 368-383, 386, 388-393, 395-401, 405-461, 406-411, 413-418, 414-417, 420-423, 421-422, 425-458, 460, 463-476, 464, 464-475, 466-474, 478-484, 479-483, 481-482, 486-489, 487-488, 491-494, 492-493, 496-498, 497, 500-531, 501-530, 511-517, 520-526, 529, 534-537, 535, 535-536, 539-541, 540, 540, 543-545, 544, 544, 547-549, 548, 551-553, 552, 555-558, 557, 3-4, 1, 16, 21, 33, 37, 49, 71, 79, 81, 93, 96, 110, 113, 132, 1-14, 1-23, 1-39, 63-64, 1-73, 91, 108, 129
Generated in workflow #594 for commit 80af032 by the Vitest Coverage Report Action
github-actions[bot] commented 1 week ago

Visit the preview URL for this PR (updated for commit 80af032):

https://roar-staging--pr857-signup-code-invitati-b3sqclzx.web.app

(expires Tue, 15 Oct 2024 18:31:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

cypress[bot] commented 1 week ago

roar-dashboard-e2e    Run #7929

Run Properties:  status check passed Passed #7929  •  git commit 80af03294e: E2E Tests for PR 857 "Suggested changes for parent sign up e2e test" from commit...
Project roar-dashboard-e2e
Run status status check passed Passed #7929
Run duration 06m 11s
Commit git commit 80af03294e: E2E Tests for PR 857 "Suggested changes for parent sign up e2e test" from commit...
Committer Kyle
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 14