Fix participant homepage loading state

maximilianoertel commented 1 day ago

Proposed changes

This PR fixes the flashing loading states on the Participant homepage.

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
[ ] Documentation Update
[ ] Tests (new or updated tests)
[ ] Style (changes to code styling)
[ ] CI (continuous integration changes)
[ ] Repository Maintenance
[ ] Other (please describe below)

[x] I have read the guidelines for contributing.
[x] The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
[x] Linting checks pass with my changes.
[x] Any existing unit tests pass with my changes.
[x] Any existing end-to-end tests pass with my changes.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
[x] I have added JSDoc comments as appropriate.
[ ] I have added the necessary documentation to the roar-docs repository.
[x] I have shared this PR on the roar-pr-reviews channel (if I have access)
[x] I have linked relevant issues (if any)

n/a

n/a

github-actions[bot] commented 1 day ago

Status	Category	Percentage	Covered / Total
🔵	Lines	5.07%	390 / 7679
🔵	Statements	4.98%	421 / 8453
🔵	Functions	6.09%	115 / 1887
🔵	Branches	2.42%	110 / 4538

File Coverage

File	Stmts	% Branch	% Funcs	% Lines	Uncovered Lines
Changed Files
src/pages/HomeParticipant.vue	0%	0%	0%	0%	109-113, 115, 117-118, 121-125, 123, 123-124, 127-128, 130-132, 131, 131, 134-136, 135, 135, 138-139, 145-147, 153-155, 157-159, 158, 158, 161, 161, 161-162, 162, 168-170, 172-174, 176-178, 177, 180-182, 181, 184-187, 185, 185-186, 190-194, 196-206, 200-204, 201-203, 205, 208-210, 212-215, 217, 219-221, 223-261, 224, 226-227, 229, 231-247, 232, 234-241, 235, 237-240, 238-239, 243-246, 244-245, 250-256, 251-255, 252-254, 257-261, 258-260, 265-269, 271-275, 278-281, 279-280, 285-327, 286-325, 287-311, 290-292, 297, 297-308, 313-322, 315-321, 316-320, 317-319, 318, 324, 326, 329-331, 330, 330, 333-335, 334, 334, 338-347, 339-346, 342, 350-352, 351, 355-357, 356, 356, 360-366, 361, 361, 363-365, 368-397, 372, 372, 375-377, 376, 379-380, 380, 383-391, 386-388, 387, 390, 394, 1, 9, 11, 26, 44-45, 56, 61, 1-32, 1-47, 49
src/pages/HomeSelector.vue	0%	0%	0%	0%	37, 37-38, 38-39, 39, 41-43, 45-46, 48, 50-53, 51-52, 55-56, 58, 60-63, 61, 61-62, 65-67, 66, 66, 69-71, 73-75, 77, 79, 79-85, 84, 87-94, 89-93, 90, 92, 96-97, 100, 104, 104, 106-107, 109, 111-115, 112-114, 117-118, 118, 120-123, 121-122, 127-129, 132-140, 135-137, 136, 142-148, 143-146, 144-145, 147, 147, 1, 3, 5

Generated in workflow #732 for commit a42ea2d by the Vitest Coverage Report Action

github-actions[bot] commented 1 day ago

Visit the preview URL for this PR (updated for commit a42ea2d):

_{(expires Tue, 22 Oct 2024 16:57:40 GMT)}

_{Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460}

cypress[bot] commented 1 day ago

Run Properties: Passed #8385 • a42ea2db19: E2E Tests for PR 889 "Fix participant homepage loading state" from commit "a42ea...

Project	`roar-dashboard-e2e`
Run status	`Passed #8385`
Run duration	`03m 41s`
Commit	`a42ea2db19: E2E Tests for PR 889 "Fix participant homepage loading state" from commit "a42ea...`
Committer	`Maximilian Oertel`
View all properties for this run ↗︎