search

yeatmanlab / roar-mep

Rapid Online Assessment of Reading -- Multiple Element Processing
Other
1 stars 3 forks source link

iOS video autoplay Issue #19

Closed celsoyh closed 1 year ago

celsoyh commented 1 year ago

I did some tests enabling/disabling the timeline.push(enter_fullscreen); and it worked when I commented on it.

So I was checking what in the enter_fullscreen could be causing the issue. I just noticed that the fullscreen event was happening at the same time that the video was trying to play because of the default delay after. So I changed the delay_after to 0 to enter full-screen mode before the video tries to play. It worked on Chrome and Safari for iOS (iPad and iPhone).

Not sure if there is any other issue, saw that there is a second video on it that is not playing but couldn't find it. When does it need to be played?

richford commented 1 year ago

Thanks @celsoyh! That was quick. For some reason the GitHub action to preview the PR on Firebase hosting is skipping. So I'm going to merge this and test on the main branch's deployment. Then I'll follow up about your questions about the second video. Thanks again.

richford commented 1 year ago

@celsoyh, thanks so much for submitting this PR. It did resolve the issue with the first video but unfortunately did not resolve the issues with the remaining videos. I reopened issue #18 accordingly and put some extra comments in there: