Consider using Moodle CURL (to support PROXY)

yedidiaklein / moodle-repository_pixabay

Moodle Repository for Pixabay images.

GNU General Public License v3.0

1 stars 5 forks source link

Closed nadavkav closed 3 years ago

nadavkav commented 3 years ago

We are blocked when trying to use this plugin from within our institute as all outside communication is directed via a reverse proxy.

Please consider changing file_get_content() https://github.com/yedidiaklein/moodle-repository_pixabay/blob/master/lib.php#L81 Into Moodle's CURL that supports PROXY admin settings.

Here is a quick suggestion (that helped us workaround this issue) //$json = file_get_contents($url); $curl = new curl(); $json = $curl->get($url);

yedidiaklein commented 3 years ago

Hi nadav, tnx! is you patch working well ?

Do you want to fork and "pull request" ?

nadavkav commented 3 years ago

Yes. seem to work well for quite some time now.

nadavkav commented 3 years ago

Added pull request #13

yedidiaklein commented 3 years ago

tnx, merged