yeehaoo / pe

0 stars 0 forks source link

Sequence diagram for history feature implementation in DG is inaccurate #18

Open yeehaoo opened 1 year ago

yeehaoo commented 1 year ago

It is stated that HistoryCommand calls the HistoryList.printlist() however in the diagram it shows that CommandResult is the class that calls printlist.

Medium severity indicated because this could cause some confusion to a new developer when he notices the differences between the diagram and the code.

image.png

soc-se-bot commented 1 year ago

Team's Response

Understandable bug but does not warrant a medium severity as if needed, the developer can look at the history command to see whether it calls command result or printList directly

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]