yeelliott / jquery-utils

Automatically exported from code.google.com/p/jquery-utils
MIT License
0 stars 0 forks source link

Value shouldn't change on mouseover only #35

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Mouseover the widget
2. Value is changed
3.

Correct behaviour:
A user should click on the hours or minutes to change the value.

Current behaviour:
Now only hovering over the widget (downwards) will change the value.

Because the chance this happens accidentally is so big and the user might
not notice it, this behaviour is unacceptable.

The risk of unintentionally changing the value is too high.

What version of the product are you using? On what operating system?
Fx 3.5/Vista.

Original issue reported on code.google.com by edwinjma...@gmail.com on 29 Aug 2009 at 8:06

GoogleCodeExporter commented 9 years ago
Edwin:
if you set option {updateLive: false, trigger: 'click'} then selection will 
popup after 
user clicks on the textbox, consequently value will be update after click;

However issue remains that after click, value will be reset to 00:00, when 
proper 
behavior as it stated: "A user should click on the hours or minutes to change 
the 
value."

Original comment by koysti...@gmail.com on 24 Mar 2010 at 8:27

GoogleCodeExporter commented 9 years ago
fixed issue that i described, change one function call to check for invalid 
values 
and only update text when value specified: 

_setVal: function(val) {
        val = val || this._getVal();

        if (!(val.h==="" && val.m===""))
        {        
            this.element.data('timepickr.initialValue', val);
            this.element.val(this._formatVal(val));        
        }

        if(this._dom.menu.is(':hidden')) {
            this.element.trigger('change');
        }
    }

Original comment by koysti...@gmail.com on 24 Mar 2010 at 9:46

GoogleCodeExporter commented 9 years ago
I've just committed your patch: 
http://code.google.com/p/jquery-utils/source/detail?
r=626

Thanks !

Original comment by hainea...@gmail.com on 24 Mar 2010 at 10:23