search

yeelp / Distinct-Damage-Descriptions

Adding physical D&D-style damage types to Minecraft to deepen the combat
MIT License
8 stars 4 forks source link

crash when use probeZS #103

Closed LingJiuQiSan closed 2 months ago

LingJiuQiSan commented 2 months ago

logs and crashreports I found that in yeelp/distinctdamagedescriptions/integration/crafttweaker/capabilities/CTResistances.java calls ed a zenclass "mods.ddd.IDDDDamageType", but the correct is "mods.ddd.damagetypes.IDDDDamageType" in yeelp/distinctdamagedescriptions/integration/crafttweaker/types/ICTDDDDamageType.java this will cause game crash when use probeZS

LingJiuQiSan commented 2 months ago

friendlyhj/ProbeZS#10

yeelp commented 2 months ago

That's pretty interesting. I'm surprised the CraftTweaker integration works at all even though this typo exists. Nice catch!

yeelp commented 2 months ago

Offending line in question:

https://github.com/yeelp/Distinct-Damage-Descriptions/blob/1432b5f2c907c472ecc2f9a1904d7c2c4b3e1dad/src/main/java/yeelp/distinctdamagedescriptions/integration/crafttweaker/capabilities/CTResistances.java#L22