search

yeelp / Distinct-Damage-Descriptions

Adding physical D&D-style damage types to Minecraft to deepen the combat
MIT License
9 stars 4 forks source link

Issue with customnpcs #67

Closed viperc48 closed 2 years ago

viperc48 commented 3 years ago

The dialogue command from customnpcs does not work when DDD is installed and debug.log shows an error. debug.log

yeelp commented 3 years ago

Seems to be that DDD can't find and attach mob resistances to the NPC, then tries to give a warning about it using the entity's name, which causes a problem with customnpcs because somehow the name doesn't exist or something

viperc48 commented 3 years ago

So the dialog commands I was testing are /noppes dialog show

and /noppes dialog read . The dialogues are drawn from the global pool of dialogues(not attached to any npc) and should show the dialogue in a menu. Normal npc dialog works fine as it is accessed by right-clicking a npc that has dialogue attached to it. Perhaps there is a way to skip DDD's check for mob resistances?

yeelp commented 3 years ago

Probably yes, but the better idea is to just check if the problem occurs and assign a default value instead of crashing, and throw a warning in the console.