search

yeelp / Scaling-Feast

A simple, balanced way to increase your maximum hunger in Minecraft over the course of a world.
MIT License
0 stars 1 forks source link

Tab-completion and entity selectors do not work in /sf setExtended??? <player> #49

Closed James103 closed 4 years ago

James103 commented 4 years ago

Mod Version: 1.3.1 Minecraft Version: 1.12.2 Loaded Mods: image (this modlist also applies to #50 and #51)

Describe the bug When using entity selectors in /sf setExtended??? <player>, it errors out with (for example) Player @p doesn't exist instead of resolving the selector (in this case, to the executor).

Additionally, tab-completion on the player name fails, with the game reporting the following error: crash-2020-05-14_15.46.48-server.txt crash-2020-05-14_15.46.30-server.txt

Steps to Reproduce

  1. Type the command /sf setExtendedMax, but don't hit enter to execute it yet.
  2. Hit tab. The game reports an error as above.
  3. With the command still up, type @p 128.
  4. Hit enter. The command /sf setExtendedMax @p 128 will execute, and error out with Player @p doesn't exist.

Expected behavior

Tab-completion and entity selectors both work in /sf setExtended??? <player>.

yeelp commented 4 years ago

Right. So I was aware that entity selectors didn't work but just completely forgot to do anything about it. At the time, I was working under some false assumptions. The code for the commands is kinda of old and could really use some updating anyway. Thanks for bringing these issues to my attention!

I can get this ironed out for 1.3.2