Closed yeelp closed 4 years ago
You have a lot of commits (23) in this PR, some of which could be grouped into just one commit. Have you considered squashing together some of the smaller commits into one for better organization of history?
You're right. Might be a good idea to do that.
Do you know how to squash and change commits, force-push, etc? These techniques are important for managing your commit history, such as here when you need to group a lot of commits together into one.
It's not something I've done before, but It's also not something I can't learn. I've squashed some of the smaller commits to bring me to 11 total commits, which I'm happy with, but I don't care much about changing the commit history in any other way right now.
Since you've over a week ahead of schedule, would it be possible to release "Scaling Feast v1.4.0-beta" so players can test the new features while you work on the rest of the features that will make it into the final 1.4.0 release?
You're right, probably a good idea. Basically exactly what I thought after I merged.
Changes for 1.4.0
[x] Closes #45
[x] Closes #47
[x] Closes #54
[x] Closes #56
[x] Closes #58
[x] Debug #45
[x] Debug #47
[x] Debug #54
[x] Debug #56
[x] Debug #58
[x] Review changes