yeelp
commented
3 years ago I'm ultimately deciding to forgo adding the dynamic hunger display (which was the only reason this issue remained open). A simpler version already exists with the Advanced Info Display. And while not as fancy, it communicates the exact same information. I see no need for redundancy.
AppleSkin tooltips are basically incompatible with Scaling Feast. You more or less have to sacrifice something. AppleCore scales max hunger to be represented by 20 shanks, and AppleSkin recognizes this and adjusts food tooltips accordingly. So, each half shank represents 5% of your total max hunger. The problem here is that this system isn't really intuitive when using Scaling Feast, since max hunger is no longer scaled in this way. You essentially have two choices (this is where the sacrifice comes in)
1) Have AppleSkin recognize AppleCore: The tooltips will be scaled as described above but everything else works as intended.
2) Have AppleSkin ignore AppleCore: The tooltips will be correct - as in, one shank in the tooltip means gaining one shank in hunger. However, changes to the food values are ignored. For example, when wearing a Gluttony chestplate, the bonus hunger restored by a food item will NOT be reflected in the tooltip.
I would have to basically recreate some kind of food tooltip myself to fix this problem. But that can open up more problems with inter-mod compatibility (Think Better With Mod's hardcore hunger module - a problem that AppleSkin addresses itself). So I'm not sure if this is something I really want to tackle.
The second thing to address is AppleSkin's dynamic hunger display in the HUD when holding food items. it would be pretty cool to have something like that (and it would wrap around too if appropriate). It could be a little complicated. If I wanted to tackle this, I'll want to rewrite the HUDOverlayHandler first for readability and add some utility methods so that drawing the HUD is a more efficient process. Since Scaling Feast is slowing down in development (at least that what it seems like), a rewrite like this might not be worth the investment.
I'm placing this issue here mainly so I don't forget about it, and also so people visiting the repo can drop their two cents in on the matter. It's entirely possible this issue goes unaddressed and closed entirely.