Hunger drains below Vanilla max

[Minecr4ck]

Mod Version: scalingfeast-1.5.3.jar Minecraft Version: 1.12 forge-14.23.5.2854 Loaded Mods: Too many to list. Will try to reproduce outside of modpack.

Describe the bug Dying reduces hunger far below "vanilla maximum". According to your config...

"death penalty" {

If not set to zero, this field indicates how much hunger you lose on death. Will not bring your respawning hunger value below vanilla's default maximum

        # Min: 0
        # Max: 32767
        I:"Hunger Lost on Death"=10

        # If not set to zero, this field indicates how much of your maximum hunger you lose upon death. Can not go below the default vanilla maximum.
        # Min: 0
        # Max: 32767
        I:"Max Lost on Death"=20
    }

With these settings, my hunger gets drained down to 1 shank.

Steps to Reproduce Die repeatedly until hunger is lowered. Usually just 1-3 times from baseline vanilla max(depending on settings of course) !

Expected behavior I was expecting that hunger would stop being permanently reduced at 10 shanks(vanilla max)

Screenshots

[Minecr4ck]

Tested with just Scaling Feast 1.5.3 and Applecore 3.4.0, same result.

[yeelp]

Hmmm.... I wonder if capping it at the vanilla max was a paranoid precaution that I realized wasn't a problem and then simply ignored, and then forgot to change the config text. I'll add a configurable lower cap though, as that seems like a reasonable addition.

EDIT: Actually, on further inspection, what's going on here is you have Hunger Lost on Death and Max Hunger Lost on Death set. The Max Hunger Lost on Death ignores any lower cap, but the Hunger Lost on Death will keep your respawning hunger no lower than the vanilla maximum. Since your max hunger gets lowered beyond the vanilla maximum, your respawning hunger is merely set as high as it can go. So this technically isn't a bug, but it does highlight a useful feature that will clear up any confusion.

[Minecr4ck]

So what your saying is... If MAX HUNGER LOST ON DEATH is set to VANILLA MAX or higher(20+), then player will not lose health below that. BUT because I had set it to lower than VANILLA MAX, then things go goofy and decided to ignore the lower cap? (in this case, 10)

I'll test this on my end in the near future