1.12.2 Max Hunger Limit Reset after relog.

yeelp / Scaling-Feast

A simple, balanced way to increase your maximum hunger in Minecraft over the course of a world.

MIT License

0 stars 1 forks source link

1.12.2 Max Hunger Limit Reset after relog. #97

Closed P3rf3ctXZer0 closed 3 years ago

P3rf3ctXZer0 commented 3 years ago

Mod Version: 1.6.1 Minecraft Version: 1.12.2 Loaded Mods: https://www.technicpack.net/modpack/pixelmon-evolved-zer0-edition.1763938 Describe the bug During testing I noticed my default max health is reset back to 20.0 it was last left at 36.00

Steps to Reproduce Run my pack through join server increase hunger and log off.

Expected behavior Max Hunger remain through logging off and logging on.

Screenshots Forget to get them.

Additional context None so far. If you want to be modded on my server dev I can mod you for testing purposes.

yeelp commented 3 years ago

I'm guessing this only happens in multiplayer? I haven't ever had this happen to me in single player from what I remember. So I'm guessing this is a packet thing, but I'm fairly positive I've handled that correctly. Seems like I missed something.

The solution should be really easily to implement if I can find the exact cause of the issue. A few questions that could help, if you have the time:

Does the max hunger gained from Hearty Shanks disappear?
Does the max hunger gained from the /sf command disappear? (I believe it's something like /sf setMax or /sf setExtendedMax with arguments and )
Does max hunger gained/lost from Spice of Life (and SOL:Carrot) disappear?

If it's yes to all three, then that's an annoying problem to solve. If at least one of them stays on a relog, then that should help me a ton to find the problem.

P3rf3ctXZer0 commented 3 years ago

Does the max hunger gained from Hearty Shanks disappear?

-- yes

Does the max hunger gained from the /sf command disappear? (I believe it's something like /sf setMax or /sf setExtendedMax with arguments and )

-- not tested

Does max hunger gained/lost from Spice of Life (and SOL:Carrot) disappear?

--- Will not test.

I will try the command thing now.

P3rf3ctXZer0 commented 3 years ago

5J1KiZt 1

Before I log off.

P3rf3ctXZer0 commented 3 years ago

Hm this time it saves ... the command keeps the data.

P3rf3ctXZer0 commented 3 years ago

Reset Hunger now trying with shank.

Mwt9lmB 1

P3rf3ctXZer0 commented 3 years ago

I ate some shanks syKwnof 1

P3rf3ctXZer0 commented 3 years ago

Seems to be working fine now ... I wonder why :(

Sereath commented 2 years ago

Old bug I know but I wanted to report that the same thing used to happen in my server and never understood why. Maybe it's fine now.

yeelp commented 2 years ago

Since 1.6.1, I've actually redone the whole hunger system which changes the way it's saved. Because of this, in 1.8.2, encountering this bug is likely impossible (although never say never haha), so make sure you're using a 1.8.0+ version (just be aware of the stats you'll lose in the transition, you can check the changelog on CurseForge for info) :+1:

P3rf3ctXZer0 commented 2 years ago

Thanks I will keep this in mind.