Fixes a dead link in docs/src/projections.md + an additional example on reprojecting

yeesian / ArchGDAL.jl

A high level API for GDAL - Geospatial Data Abstraction Library

https://yeesian.github.io/ArchGDAL.jl/stable/

Other

142 stars 26 forks source link

Fixes a dead link in docs/src/projections.md + an additional example on reprojecting #260

Closed mathieu17g closed 3 years ago

mathieu17g commented 3 years ago

Fixed a dead link to GDAL tutorial on CRS and transformations in docs/src/projections.md
Added a subset of Python GDAL/OGR Cookbook, to illustrate reprojecting on features obtained from a read dataset/layer

@visr and @yeesian: is there a way to embed a preview on documentation modifications in Github comments ?

visr commented 3 years ago

is there a way to embed a preview on documentation modifications in Github comments ?

Right now the documentation CI fails, so https://yeesian.com/ArchGDAL.jl/previews/PR260/ is not available, but a preview should become available there, until it is cleaned up automatically. See for instance https://yeesian.com/ArchGDAL.jl/previews/PR216/

Though you can always paste a screenshot if you want to discuss something in particular.

mathieu17g commented 3 years ago

Thank you. I did not know this link on previews

mathieu17g commented 3 years ago

I have found the solution on the CI issue on julia discourse: https://discourse.julialang.org/t/generation-of-documentation-fails-qt-qpa-xcb-could-not-connect-to-display/60988

mathieu17g commented 3 years ago

Right now the documentation CI fails, so https://yeesian.com/ArchGDAL.jl/previews/PR260/ is not available, but a preview should become available there, until it is cleaned up automatically. See for instance https://yeesian.com/ArchGDAL.jl/previews/PR216/

@visr do I have to do something to generate the preview, or it will be generated automatically after a while ?

mathieu17g commented 3 years ago

@visr do I have to do something to generate the preview, or it will be generated automatically after a while ?

Ah according to Documenter.jl documentation : it doesn't work for commits pushed on a fork

push_preview a boolean that specifies if preview documentation should be deployed from pull requests or not. If your published documentation is hosted at "https://USER.github.io/PACKAGE.jl/stable, by default the preview will be hosted at "https://USER.github.io/PACKAGE.jl/previews/PR##". This feature works for pull requests with head branch in the same repository, i.e. not from forks.

So here is a screen capture:

mathieu17g commented 3 years ago

@yeesian I have just spotted that there was an all issue #72, that may be linked to this PR

Is the simple example provided above enough or you would like to transpose the whole Python GDAL/OGR Cookbook retroject example in Julia ?

yeesian commented 3 years ago

(Btw, you have contributor access to this package so feel free to create branches from it in the future if you'd like)