mattwigway
commented
3 years ago Okay, addressed the style comment, and added a test that checks that errors are thrown, and that the error messages are correct. Let me know if there's anything else I can do!
The @ogrerr macro just printed whatever was passed to it in the source, which was often unhelpful (for instance, in
setfeature!, "Failed to set feature." This change prints a human-readable message based on the OGR error code, in addition to the message passed to ogrerr.