search

yeesian / ArchGDAL.jl

A high level API for GDAL - Geospatial Data Abstraction Library
https://yeesian.github.io/ArchGDAL.jl/stable/
Other
141 stars 27 forks source link

Generalise geomtypes #305

Closed rafaqz closed 2 years ago

rafaqz commented 2 years ago

This PR allows creating points with any Real numbers.

It also cleans up the code generation code used for createpoint etc, simplifying and reducing indentation level.

Closes #304

yeesian commented 2 years ago

Thank you for this! It seems the only remaining method to be covered is createmultipolygon(::Vector{Vector{T} where T}). Apart from that, the rest seem to be pertaining more to some of the GeoInterface methods to be implemented.

rafaqz commented 2 years ago

Sorry where is the missing createmultipolygon? I can't see where that was even originally implemented.

Edit: sorry I see it's just missing types on in the tests.

rafaqz commented 2 years ago

Yes sometimes when you delete code you delete more lines that were covered than lines that weren't, so it looks like you've reduced test coverage. But the amount of funcitonality covered hasn't actually changed.