search

yeesian / ArchGDAL.jl

A high level API for GDAL - Geospatial Data Abstraction Library
https://yeesian.github.io/ArchGDAL.jl/stable/
Other
142 stars 26 forks source link

introduce a vector dataset writer #315

Closed maxfreu closed 2 years ago

maxfreu commented 2 years ago

Hi! Here comes the vector dataset writer. It still is far from perfect and needs tests, but you can already take a look.

maxfreu commented 2 years ago

Seems like some tests are still failing on mac and windows, maybe I have to remove some drivers from the test and rewrite the test a bit.

maxfreu commented 2 years ago

I just removed the writerasters again and implemented the comments you have made. I hope it looks better now :)

maxfreu commented 2 years ago

I just got the tests on windows to pass. The failing tests on mac look unrelated.

maxfreu commented 2 years ago

Ok next round. I improved the GPKG workaround, restored the old definition of deletefeaturedefn and changed GDTUnknown to Any in create. So I think the last point is whether to add the type annotation for dtype, which I think is maybe not necessary as the name already suggests what it is for.

maxfreu commented 2 years ago

I just switched the default of use_gdal_copy to true, made per-layer options possible (given as vector instead of dict), changed the docs and added some tests.

maxfreu commented 2 years ago

layer_options now expects a Dict and I changed some type annotations. Thanks for the comments! Hope it is fine now, but don't hesitate to insist if you still dislike sth.

maxfreu commented 2 years ago

Has been a pleasure! Thanks for the comments and let's see where this takes us :)