search

yeesian / ArchGDAL.jl

A high level API for GDAL - Geospatial Data Abstraction Library
https://yeesian.github.io/ArchGDAL.jl/stable/
Other
142 stars 26 forks source link

Add support for complex and 64bit integers #327

Closed yeesian closed 2 years ago

yeesian commented 2 years ago

Fixes #326

visr commented 2 years ago

Nice, also fixes #298

yeesian commented 2 years ago

I don't really understand the @convert macro and why we need these two steps of conversion. It feels like this could be a maintenance problem long term?

Yeah it could be a maintenance problem long term; my guess is that the complexity arises from handling the variety of different expressions (depending on whether it's an enum, cenum, datatype, etc) in https://github.com/yeesian/ArchGDAL.jl/blob/4626113a968a7e369de67682df52ca9f26979ad9/src/types.jl#L268-L590.

In the meantime, we can examine the output of that macro using macroexpand like in https://github.com/yeesian/ArchGDAL.jl/issues/326#issuecomment-1258826512 for debugging purposes.