search

yeesian / ArchGDAL.jl

A high level API for GDAL - Geospatial Data Abstraction Library
https://yeesian.github.io/ArchGDAL.jl/stable/
Other
141 stars 27 forks source link

[breaking] switch from Base.convert to GeoInterface.convert #359

Closed visr closed 1 year ago

visr commented 1 year ago

This is a breaking change.

For background see https://github.com/JuliaGeo/GeoInterface.jl/pull/66. Brought up in https://github.com/yeesian/ArchGDAL.jl/issues/189#issuecomment-1368537576.

Soon https://github.com/JuliaGeo/GeoInterface.jl/pull/85 will provide extra options for conversion, though this doesn't help ArchGDAL as much, since you always convert to IGeometry anyway. And it is not breaking so no need to wait for that.

After this is in, shall we tag v0.10?

yeesian commented 1 year ago

Added "[breaking]" to the title so we might get reminded of it when tagging for the next release: https://github.com/yeesian/ArchGDAL.jl/compare/v0.9.4...master

visr commented 1 year ago

Thanks, yes I also added a "breaking" label that helps with querying PRs.

What do you think, should we tag 0.10 now? Would be nice to have GDAL 3.6 available.

yeesian commented 1 year ago

https://github.com/yeesian/ArchGDAL.jl/commit/dd34eedd7605d350811f614adcebe20cd15c3f11#commitcomment-95375145