search

yeesian / ArchGDAL.jl

A high level API for GDAL - Geospatial Data Abstraction Library
https://yeesian.github.io/ArchGDAL.jl/stable/
Other
141 stars 27 forks source link

Forward GeoInterface.centroid #365

Open asinghvi17 opened 1 year ago

asinghvi17 commented 1 year ago

~This doesn't work for FeatureCollections yet, and no tests have been added. It's essentially a quick and dirty implementation where I extended the type constraints on the main GeoInterface.convert method and implemented ArchGDAL.geointerface_geomtype(arg) = IGeometry. Since it operates on traits, it seemed a fair bet, and any feature-like object can of course be overloaded.~

Changed the PR to just forward GeoInterface.centroid, which seemed to be missing.

rafaqz commented 1 year ago

This is already tested as working. But yes we also need to handle features somehow. I guess I should have handle that in GeoInterface as well.

rafaqz commented 1 year ago

A test ?