search

yeg-relief / issue-tracker

This repo tracks issues that require features in multiple tiers of the YouCanBenefit application.
1 stars 0 forks source link

toggle questions #12

Closed slmyers closed 6 years ago

slmyers commented 6 years ago

toggle questions without a selection result in value "" which seems to imply true in the backend for generating screener results.

Lucase4c commented 6 years ago

Hey Steven,

How much of an issue do you feel this is? I feel like it errs on the side of a false positive which is not a bad thing.

What do you think?

Lucas Stone e4c Financial Empowerment Coordinator

LStone@e4calberta.orgmailto:LStone@e4calberta.org T 780.424.5408 x163 C 780.554.0894

9321 Jasper Avenue, Edmonton AB T5H 3T7

e4calberta.orghttps://e4calberta.org/

[cid:MainLogo_55796721-010e-435f-9c40-0dc1a644656e.png]

This message is intended for the use of the individual or entity to which it is addressed and may contain information that is privileged and confidential. If you are not the intended recipient or the employee responsible for delivery of the message to the intended recipient, please be advised that any dissemination, distribution or copying of this message is strictly prohibited. If you have received this message in error, please notify us immediately by telephone and return the original email to us or destroy this message.

[cid:Environmentlogo_5cc24339-3bc0-40ee-87a1-6b0a51bb24dc.png]e4c supports environmental conservation - please print wisely. From: Steven Myers [mailto:notifications@github.com] Sent: Sunday, October 01, 2017 10:39 AM To: yeg-relief/issue-tracker issue-tracker@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [yeg-relief/issue-tracker] toggle questions (#12)

toggle questions without a selection result in value "" which seems to imply true in the backend for generating screener results.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/yeg-relief/issue-tracker/issues/12, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Abj_1GB533dcZP12eUeIG-1aBZyEn1agks5sn8AqgaJpZM4Pp8sa.

slmyers commented 6 years ago

Well right now with 0 data filled on form you get a hit on Disability Tax Credit. I'm not sure if this is ideal.

Regardless, I feel like this is low priority -- even if it messes with results a bit. It is probably best for me to keep working on the style/presentation of the front end.

slmyers commented 6 years ago

toggle type is present in client app