search

yeg-relief / youcanbenefit

YouCanBenefit is a web application that increases social benefit program discoverability for people of lesser means and their allies.
https://youcanbenefit.edmonton.ca
MIT License
13 stars 9 forks source link

update app routes and redesign 404 page #124

Closed TheBroMoe closed 5 years ago

TheBroMoe commented 5 years ago

closes #20

Made small changes in redirecting the PageNotFoundComponent in app.routes.ts after referring to resources online relating to creating an angular 404 component for Versions of Angular newer than v2.2.2 and newer. You can look at the link I found Here

Talking to @CodyGramlich, he recommended deploying a test version of the environment to confirm the change will work in the production environment.

I also didn't touch the front end side of the page not found component, because I wasn't sure of any particular edits we may want to make to it, but I can make changes if necessary.

Thanks! Mohammad Kebbi

TheBroMoe commented 5 years ago

The 404 page has been redesigned and now looks like this:

Screenshot from 2019-05-04 21-17-06

Please let me know your thoughts or if you have any suggestions for any changes! Thanks!

j-rewerts commented 5 years ago

This looks great! Thanks @TheBroMoe !! I think Cody is right, I'll need to set up a test environment for this, since we have Kubernetes Ingress to worry about for 404 routing.

CodyGramlich commented 5 years ago

@TheBroMoe Could you remove this line? It sometimes covers the text based on the size of the window. 404-page-line

Other than that, this looks good to be merged.

TheBroMoe commented 5 years ago

Line has been taken out and I made some changes so that the page should more responsive as well