search

yeg-relief / youcanbenefit

YouCanBenefit is a web application that increases social benefit program discoverability for people of lesser means and their allies.
https://youcanbenefit.edmonton.ca
MIT License
13 stars 9 forks source link

Create document fetching #78

Closed TheBroMoe closed 5 years ago

TheBroMoe commented 5 years ago
TheBroMoe commented 5 years ago

Hi @TheBroMoe thanks for your contribution. I think you found an unrelated bug (second last comment). Perhaps you wouldn't mind cleaning it up in this pr?

I wonder if this couldn't be extended with some type of interface in the admin section for generating the document. Not sure if it's a priority, but I do think that this PR will make the /about section cumbersome to edit. The dynamicDocument editor could tie in with the Rich Text Editor (future) implementation. Perhaps you've been thinking about this already.

I'll be sure to look into everything you mentioned. Thank you for the Feedback! I'll resend a PR when I've made all the changes.

TheBroMoe commented 5 years ago

Almost everything mentioned should now be resolved. I'm still looking into extending the service with the admin interface mentioned earlier. Be sure to look over the request again and let me know if there are any changes I should make. Thanks!

j-rewerts commented 5 years ago

Closing in lieu of #108.