none: tidy used item and trim tail spaces

yegappan / lsp

Language Server Protocol (LSP) plugin for Vim9

MIT License

458 stars 49 forks source link

none: tidy used item and trim tail spaces #437

Closed Shane-XB-Qian closed 1 week ago

Shane-XB-Qian commented 8 months ago

trim tail spaces
pick up some to key

Shane-XB-Qian commented 8 months ago

Why "abbr" and "dup" fields are removed from the key?

had 'word' already,
'dup' maybe all same val.

-- shane.xb.qian

yegappan commented 8 months ago

Why "abbr" and "dup" fields are removed from the key?

had 'word' already, - 'dup' maybe all same val.

it is better to keep abbr and dup to make sure there are no duplicates. Note that a completion item may have abbr in addition to word.

Shane-XB-Qian commented 8 months ago

Why "abbr" and "dup" fields are removed from the key?

had 'word' already, - 'dup' maybe all same val.

it is better to keep abbr and dup to make sure there are no duplicates. Note that a completion item may have abbr in addition to word.

i think should think about 'overhead', should not put too much things to make up a huge 'key'; that functionality was trying to remove dup compl items, how come 'abbr' was a matter to that?

-- shane.xb.qian

girishji commented 7 months ago

Please do not remove dup. If LSP sends a snippet back and if the abbr or word matches a buffer word completion or vsnip completion, it will not show.

Shane-XB-Qian commented 7 months ago

Please do not remove dup.

remove where? if you meant in that compl items itself, then it should not and would not.

If LSP sends a snippet back and if the abbr or word matches a buffer word completion or vsnip completion, it will not show.

are they same kind? was this really the problem?