yegappan / lsp

Language Server Protocol (LSP) plugin for Vim9
MIT License
489 stars 60 forks source link

Highlight color of `LspSigActiveParameter` is probably not appropriate. #456

Open beavailable opened 9 months ago

beavailable commented 9 months ago

I use onedark as the theme for vim, I found that the color of LspSigActiveParameter is gray that I can barely see it.

After some research, I found out that the color is linked to LineNr:

hlset([{name: 'LspSigActiveParameter', default: true, linksto: 'LineNr'}])

Many users use a dark theme for vim and the color of LineNr is gray, so I thought that linking LspSigActiveParameter to LineNr may not be a good idea.

Additionally, I think that linking LspSigActiveParameter to Special may be good (at least in my case) and the color is blue in onedark theme.

yegappan commented 9 months ago

You can override the highlight groups used by the plugin. In your .vimrc file, before adding the plugin, you can define the highlight group:

   highlight link LspSigActiveParameter Special

In my local Ubuntu setup, I see that the LineNr highlight group is using the Yellow foreground color and on MS-Windows, it is using Brown. Are you using a color scheme, that changes this highlight group?

beavailable commented 9 months ago

Yes, onedark changes the color of LineNr and I think that's good, because most users don't need a highlighted color for line number, but they need a highlighted color for LspSigActiveParameter. What I mean is that linking LspSigActiveParameter to LineNr is not appropriate for many users who're using a dark theme and not appropriate semantically.

I could change this in my vimrc, but I still think it's a better idea to link to Special. However, it's up to you.