yegappan / mru

Most Recently Used (MRU) Vim Plugin
Other
259 stars 48 forks source link

Use global fzf window layout for FZFMru command #55

Closed mmrwoods closed 2 years ago

mmrwoods commented 2 years ago

It seems odd to load FZFMru with a different layout to other FZF commands, so remove the down option override when calling fzf#wrap.

I think I understand why this was added, it makes the FZFMru window the same layout as other MRU windows (when not set to use current window), but this really isn't an MRU window, it's a FZF window with MRU files.

mmrwoods commented 2 years ago

Looking at this a little closer, I now also wonder whether the s:MRU_Window_Edit_File function should be used to open a selected file from the FZF window. While I personally really like that this will useopen, that is not consistent with other FZF commands which AFAIK will always uselast (even windows with special buffers, unless you have hacked a workaround).

mmrwoods commented 2 years ago

Thanks for merging :-)