Closed iakunin closed 5 years ago
Merging #100 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #100 +/- ##
=========================================
Coverage 95.19% 95.19%
Complexity 76 76
=========================================
Files 20 20
Lines 208 208
Branches 13 13
=========================================
Hits 198 198
Misses 7 7
Partials 3 3
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
src/main/java/org/cactoos/http/Get.java | 100% <ø> (ø) |
1 <0> (ø) |
:arrow_down: |
src/main/java/org/cactoos/http/HtTimedWire.java | 100% <100%> (ø) |
2 <1> (ø) |
:arrow_down: |
src/main/java/org/cactoos/http/HtHeaders.java | 100% <100%> (ø) |
4 <0> (ø) |
:arrow_down: |
src/main/java/org/cactoos/http/HtCookies.java | 100% <100%> (ø) |
4 <3> (ø) |
:arrow_down: |
...ain/java/org/cactoos/http/HtKeepAliveResponse.java | 100% <100%> (ø) |
3 <1> (ø) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 701b89a...74259a4. Read the comment docs.
@paulodamaso seems that there is no assignee to review this PR
@0crat status
@0crat status (here)
@paulodamaso This is what I know about this job in C63314D6Z, as in §32:
REV
@fabriciofx @paulodamaso could you review this PR, please?
@paulodamaso can you refuse it for @fabriciofx so that someone else is assigned?
@iakunin @0crat should make it. lf I unassign him, he won't be penalized by the delay, so let's see why @0crat isn't unassigning people
@iakunin Filed an issue in https://github.com/zerocracy/farm/issues/2196
@paulodamaso great! Thank you
@fabriciofx @iakunin Thanks people
@rultor merge
@rultor merge
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here
@rultor merge
@paulodamaso Done! FYI, the full log is here (took me 10min)
Code review was too long (17 days), architects (@paulodamaso) were penalized, see §55
@0crat quality bad
@sereshqua could you explain why the quality is bad? I as a developer tried my best to get this task done, but eventually I got no reward. Why’s that?
@iakunin it is not related to you, it is the code reviewer who has just accepted PR without finding any issue
@sereshqua thank you for the explanation
This is for https://github.com/yegor256/cactoos-http/issues/99
There are so many files affected because I've updated
cactoos
as it was mentioned in todo.