yegor256 / cactoos-http

Object-Oriented HTTP Client
MIT License
37 stars 28 forks source link

(#99) Using org.cactoos.scalar.Binary instead of procedural code #100

Closed iakunin closed 5 years ago

iakunin commented 5 years ago

This is for https://github.com/yegor256/cactoos-http/issues/99

There are so many files affected because I've updated cactoos as it was mentioned in todo.

codecov-io commented 5 years ago

Codecov Report

Merging #100 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #100   +/-   ##
=========================================
  Coverage     95.19%   95.19%           
  Complexity       76       76           
=========================================
  Files            20       20           
  Lines           208      208           
  Branches         13       13           
=========================================
  Hits            198      198           
  Misses            7        7           
  Partials          3        3
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/cactoos/http/Get.java 100% <ø> (ø) 1 <0> (ø) :arrow_down:
src/main/java/org/cactoos/http/HtTimedWire.java 100% <100%> (ø) 2 <1> (ø) :arrow_down:
src/main/java/org/cactoos/http/HtHeaders.java 100% <100%> (ø) 4 <0> (ø) :arrow_down:
src/main/java/org/cactoos/http/HtCookies.java 100% <100%> (ø) 4 <3> (ø) :arrow_down:
...ain/java/org/cactoos/http/HtKeepAliveResponse.java 100% <100%> (ø) 3 <1> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 701b89a...74259a4. Read the comment docs.

0crat commented 5 years ago

Job #100 is now in scope, role is REV

iakunin commented 5 years ago

@paulodamaso seems that there is no assignee to review this PR

paulodamaso commented 5 years ago

@0crat status

0crat commented 5 years ago

@0crat status (here)

@paulodamaso This is what I know about this job in C63314D6Z, as in §32:

iakunin commented 5 years ago

@fabriciofx @paulodamaso could you review this PR, please?

iakunin commented 5 years ago

@paulodamaso can you refuse it for @fabriciofx so that someone else is assigned?

paulodamaso commented 5 years ago

@iakunin @0crat should make it. lf I unassign him, he won't be penalized by the delay, so let's see why @0crat isn't unassigning people

0crat commented 5 years ago

Are you speaking to me or about me here; you must always start your message with my name if you want to address it to me, see §1

paulodamaso commented 5 years ago

@iakunin Filed an issue in https://github.com/zerocracy/farm/issues/2196

iakunin commented 5 years ago

@paulodamaso great! Thank you

paulodamaso commented 5 years ago

@fabriciofx @iakunin Thanks people

paulodamaso commented 5 years ago

@rultor merge

rultor commented 5 years ago

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 5 years ago

@rultor merge

@paulodamaso Done! FYI, the full log is here (took me 10min)

0crat commented 5 years ago

@sereshqua/z please review this job completed by @fabriciofx/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

0crat commented 5 years ago

Code review was too long (17 days), architects (@paulodamaso) were penalized, see §55

0crat commented 5 years ago

The job #100 is now out of scope

0crat commented 5 years ago

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @paulodamaso/z

sereshqua commented 5 years ago

@0crat quality bad

0crat commented 5 years ago

Quality is low, no payment, see §31

0crat commented 5 years ago

Quality review completed: +4 point(s) just awarded to @sereshqua/z

iakunin commented 5 years ago

@sereshqua could you explain why the quality is bad? I as a developer tried my best to get this task done, but eventually I got no reward. Why’s that?

sereshqua commented 5 years ago

@iakunin it is not related to you, it is the code reviewer who has just accepted PR without finding any issue

iakunin commented 5 years ago

@sereshqua thank you for the explanation