(#64) HtAutoClosedResponse

[victornoel]

This is for #64.

• I added many todos to continue the work and also improve things related
• Introduced HtAutoClosedResponse that closes the response when EOF is reached
• For now the test mainly passes because of the current implementation of HtWire but when #63 is solved, the test should still pass and prove its usefulness.

@llorllale I made some design choices here, please review them carefully too :)

[0crat]

Job #79 is now in scope, role is REV

[codecov-io]

Codecov Report

Merging #79 into master will decrease coverage by 0.5%. The diff coverage is 90%.

@@            Coverage Diff             @@
##             master     #79     +/-   ##
==========================================
- Coverage        95%   94.5%   -0.5%     
- Complexity       69      75      +6     
==========================================
  Files            17      19      +2     
  Lines           180     200     +20     
  Branches         20      21      +1     
==========================================
+ Hits            171     189     +18     
- Misses            4       6      +2     
  Partials          5       5

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/org/cactoos/http/HtResponse.java	72.72% <ø> (ø)	3 <0> (ø)	:arrow_down:
...in/java/org/cactoos/http/HtAutoClosedResponse.java	100% <100%> (ø)	2 <2> (?)
...ava/org/cactoos/http/io/AutoClosedInputStream.java	87.5% <87.5%> (ø)	4 <4> (?)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 52e8b09...9c2c0c7. Read the comment docs.

[llorllale]

@victornoel a couple of minor comments

[victornoel]

@llorllale it's done, thanks

[0crat]

This pull request #79 is assigned to @vzurauskas/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

[victornoel]

@vzurauskas indeed, very good point, I removed all state from the class and only auto-close and forwards calls to read or close if reading or closing happens again.

[vzurauskas]

@victornoel Looks good. But Codecov's checks are failing, it seems to want more tests.

[victornoel]

@vzurauskas I've tried to increase coverage a bit, but I don't think I will be able to cover everything there because testing of InputStream is quite tricky. I've also noted your comment about this being a bit too much work, I agree, I will restrain myself in the future, thanks for the reminder.

@llorllale concerning coverage, I can add a @todo to introduce some abstraction to better test input streams implementation and their behaviour maybe?

[llorllale]

@victornoel @vzurauskas coverage checks are currently enforced only in cactoos-matchers :)

@vzurauskas waiting on your final verdict for this PR..

[llorllale]

@rultor merge

[rultor]

@rultor merge

@llorllale OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@llorllale Done! FYI, the full log is here (took me 12min)

[0crat]

@sereshqua/z please review this job completed by @vzurauskas/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

[sereshqua]

@vzurauskas please make sure, that next time you will find at least 3 issues when doing a code as written in the policy

[0crat]

The job #79 is now out of scope

[0crat]

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @llorllale/z

[vzurauskas]

@sereshqua Will do.

[sereshqua]

@0crat quality acceptable

[0crat]

Order was finished, quality is "acceptable": +15 point(s) just awarded to @vzurauskas/z

[0crat]

Quality review completed: +4 point(s) just awarded to @sereshqua/z