yegor256 / cactoos-http

Object-Oriented HTTP Client

MIT License

37 stars 28 forks source link

(#77) Simplify BoundedByteBuffer #85

Closed vzurauskas closed 5 years ago

vzurauskas commented 5 years ago

This is for https://github.com/yegor256/cactoos-http/issues/77.

I refactored the BoundedByteBuffer to make it simpler.

0crat commented 5 years ago

Job #85 is now in scope, role is REV

0crat commented 5 years ago

This pull request #85 is assigned to @ilyakharlamov/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

codecov-io commented 5 years ago

Codecov Report

Merging #85 into master will increase coverage by 1.04%. The diff coverage is 95.45%.

@@             Coverage Diff              @@
##             master      #85      +/-   ##
============================================
+ Coverage      94.5%   95.54%   +1.04%     
  Complexity       75       75              
============================================
  Files            19       19              
  Lines           200      202       +2     
  Branches         21       13       -8     
============================================
+ Hits            189      193       +4     
  Misses            6        6              
+ Partials          5        3       -2

Impacted Files	Coverage Δ	Complexity Δ
...in/java/org/cactoos/http/io/BoundedByteBuffer.java	`96.42% <95.45%> (+7.96%)`	`13 <12> (ø)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c2c0c7...59bd6c6. Read the comment docs.

ilyakharlamov commented 5 years ago

@llorllale good to merge in my opinion

vzurauskas commented 5 years ago

@llorllale ping

llorllale commented 5 years ago

@rultor merge

rultor commented 5 years ago

@rultor merge

@llorllale OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 5 years ago

@rultor merge

@llorllale Done! FYI, the full log is here (took me 12min)

0crat commented 5 years ago

Code review was too long (21 days), architects (@llorllale) were penalized, see §55

0crat commented 5 years ago

The job #85 is now out of scope

0crat commented 5 years ago

@sereshqua/z please review this job completed by @ilyakharlamov/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

0crat commented 5 years ago

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @llorllale/z

sereshqua commented 5 years ago

@0crat quality good

0crat commented 5 years ago

Order was finished, quality is "good": +20 point(s) just awarded to @ilyakharlamov/z

0crat commented 5 years ago

Quality review completed: +4 point(s) just awarded to @sereshqua/z