(#78) HtWire doesn't close the Socket Input

[victornoel]

This is for #78.

I had to bump the version of cactoos-matchers to be able to write/fix some of the needed tests.

I introduced a new todo to fix another test related to HtTimedWire that stopped working.

[0crat]

Job #86 is now in scope, role is REV

[codecov-io]

Codecov Report

Merging #86 into master will decrease coverage by 0.53%. The diff coverage is 100%.

@@             Coverage Diff              @@
##             master      #86      +/-   ##
============================================
- Coverage      94.5%   93.96%   -0.54%     
+ Complexity       75       74       -1     
============================================
  Files            19       19              
  Lines           200      199       -1     
  Branches         21       21              
============================================
- Hits            189      187       -2     
- Misses            6        7       +1     
  Partials          5        5

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/org/cactoos/http/HtWire.java	92.59% <100%> (-0.27%)	10 <2> (ø)
...ava/org/cactoos/http/io/AutoClosedInputStream.java	81.25% <0%> (-6.25%)	3% <0%> (-1%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c2c0c7...3ef9db5. Read the comment docs.

[0crat]

This pull request #86 is assigned to @ilyakharlamov/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

[victornoel]

@ilyakharlamov I've seen your comments, but because of zerocracy/farm#1885 and zerocracy/farm#2030 I will wait to be assigned back on the jobs before finishing them.

[victornoel]

@ilyakharlamov I've answered your comments

[ilyakharlamov]

@rultor merge

[rultor]

@rultor merge

@ilyakharlamov Thanks for your request. @llorllale Please confirm this.

[0crat]

This pull request #86 is assigned to @vzurauskas/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

[victornoel]

@llorllale can we get this merged? It's blocking other jobs

[llorllale]

@rultor merge

[rultor]

@rultor merge

@llorllale OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@llorllale Done! FYI, the full log is here (took me 11min)

[0crat]

Job was finished in 25 hours, bonus for fast delivery is possible (see §36)

[0crat]

Job #86 is not in the agenda of @vzurauskas/z, can't inspect

[0crat]

@sereshqua/z please review this job completed by @vzurauskas/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

[0crat]

The job #86 is now out of scope

[0crat]

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @llorllale/z

[sereshqua]

@0crat quality good

[0crat]

Order was finished, quality is "good": +25 point(s) just awarded to @vzurauskas/z

[0crat]

Quality review completed: +4 point(s) just awarded to @sereshqua/z