yegor256 / cactoos-http

Object-Oriented HTTP Client

MIT License

37 stars 28 forks source link

(#80) Read from streams in tests without closing #88

Closed victornoel closed 5 years ago

victornoel commented 5 years ago

This is for #80:

introduced an abstraction to read from a stream without closing it
use it to actually test that what is read is correct in the various tests

0crat commented 5 years ago

Job #88 is now in scope, role is REV

codecov-io commented 5 years ago

Codecov Report

Merging #88 into master will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #88   +/-   ##
=========================================
  Coverage     95.02%   95.02%           
  Complexity       74       74           
=========================================
  Files            19       19           
  Lines           201      201           
  Branches         13       13           
=========================================
  Hits            191      191           
  Misses            7        7           
  Partials          3        3

Impacted Files	Coverage Δ	Complexity Δ
...ava/org/cactoos/http/io/AutoClosedInputStream.java	`81.25% <0%> (ø)`	`3% <0%> (ø)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 10e6bf4...19720b8. Read the comment docs.

0crat commented 5 years ago

This pull request #88 is assigned to @vzurauskas/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

victornoel commented 5 years ago

@vzurauskas ping

victornoel commented 5 years ago

@vzurauskas I've answered your comments and committed changes

llorllale commented 5 years ago

@victornoel try rebasing on master

victornoel commented 5 years ago

@vzurauskas @llorllale it's fixed normally, but please read it again because I had forgotten some classes in my last push apparently

vzurauskas commented 5 years ago

@llorllale Looks good.

llorllale commented 5 years ago

@rultor merge

rultor commented 5 years ago

@rultor merge

@llorllale OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 5 years ago

@rultor merge

@llorllale Done! FYI, the full log is here (took me 19min)

0crat commented 5 years ago

@sereshqua/z please review this job completed by @vzurauskas/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

0crat commented 5 years ago

Code review was too long (16 days), architects (@llorllale) were penalized, see §55

0crat commented 5 years ago

The job #88 is now out of scope

0crat commented 5 years ago

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @llorllale/z

sereshqua commented 5 years ago

@0crat quality good

0crat commented 5 years ago

Quality review completed: +4 point(s) just awarded to @sereshqua/z

0crat commented 5 years ago

Order was finished, quality is "good": +20 point(s) just awarded to @vzurauskas/z